Page MenuHomePhabricator

version.getversion_svn fails for Python 3.8
Closed, ResolvedPublicBUG REPORT

Description

version.getversion_svn fails for Python 3.8 but probably since Python 3.6

C:\pwb\SVN\core>pwb.exe version
WARNING: c:\python38\lib\site-packages\pywikibot\version.py:119: DeprecationWarning: pywikibot.version.getversion_svn is deprecated for 5 years and 1 month; use getversion_svn_setuptools instead.
  (tag, rev, date, hsh) = vcs_func(_program_dir)

WARNING: c:\python38\lib\site-packages\pywikibot\version.py:270: DeprecationWarning: pywikibot.version.svn_rev_info is deprecated for 5 years and 1 month; use getversion_svn_setuptools instead.
  tag, rev, date = svn_rev_info(_program_dir)

Pywikibot: pywikibot/__init__.py (, -1 (unknown), 2020/05/25, 15:30:08, UNKNOWN)
Release version: 3.1.dev0
requests version: 2.22.0
  cacerts: c:\python38\lib\site-packages\certifi\cacert.pem
    certificate test: ok
Python: 3.8.0 (tags/v3.8.0:fa919fd, Oct 14 2019, 19:37:50) [MSC v.1916 64 bit (AMD64)]
PYWIKIBOT_DIR: Not set
PYWIKIBOT_DIR_PWB: c:\python38\lib\site-packages\pywikibot\scripts
PYWIKIBOT_NO_USER_CONFIG: Not set
Config base dir: C:\pwb\SVN\core

C:\pwb\SVN\core>

The reason is a change in time.struct_time where the n_fields attribut is 11 and bigger then the sequence length. n_sequence_fields should be used instead. I guess len() works too.

Event Timeline

Xqt triaged this task as Medium priority.May 26 2020, 9:34 AM

Change 282524 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] fix getversion_svn for Python 3.6+

https://gerrit.wikimedia.org/r/282524

Xqt changed the subtype of this task from "Task" to "Bug Report".May 26 2020, 10:00 AM

Change 282524 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] fix getversion_svn for Python 3.6+

https://gerrit.wikimedia.org/r/282524