Description

According to documentation, the shouldPreloadLogo method is deprecated and redundant. Despite this it's implemented in Vector
https://github.com/wikimedia/mediawiki/blob/master/includes/skins/Skin.php#L514

Let's remove that method from the codebase.

Details

	Subject	Repo	Branch	Lines +/-
	Drop unused override for deprecated method SkinVector::shouldPreloadLogo	mediawiki/skins/Vector	master	+0 -9

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jun 15 2020, 6:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 6:53 PM

taavi claimed this task.Jun 21 2020, 1:13 PM

Restricted Application added a project: User-Majavah. · View Herald TranscriptJun 21 2020, 1:13 PM

Change 606819 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/skins/Vector@master] Drop unused override for deprecated method SkinVector::shouldPreloadLogo

https://gerrit.wikimedia.org/r/606819

gerritbot added a project: Patch-For-Review.Jun 21 2020, 1:28 PM

taavi moved this task from Upcoming to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 21 2020, 1:28 PM

Maintenance_bot moved this task from Unsorted to Working on on the User-Majavah board.Jun 21 2020, 2:15 PM

Change 606819 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Drop unused override for deprecated method SkinVector::shouldPreloadLogo

https://gerrit.wikimedia.org/r/606819

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 21 2020, 6:00 PM

taavi closed this task as Resolved.Jun 22 2020, 1:05 PM

Maintenance_bot moved this task from Working on to Done on the User-Majavah board.Jun 22 2020, 1:15 PM