Page MenuHomePhabricator
Create Task
Maniphest T255500

DSR info not present on mw:DisplaySpace
Closed, ResolvedPublic
Actions

Description

Resulting in,

error/diff Bad dsr for SPAN: <span typeof="mw:DisplaySpace mw:Placeholder" data ...

Those were omitted in T197879 but seems like a no-no.

Details

SubjectRepoBranchLines +/-
Compute DSR info for mw:DisplaySpacemediawiki/services/parsoidmaster+49 -4
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Jun 15 2020, 9:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 9:37 PM
Arlolra triaged this task as High priority.Jun 15 2020, 9:37 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra added a comment.Jun 15 2020, 9:55 PM
17:54 <subbu> if you need a test page for T255500 I think it is arwiki النادي الأهلي (طرابلس)
17:54 <subbu> or enwiki List of future tallest buildings
17:54 <subbu> as in I don't know which one it is :-) 
17:54 <subbu> but probably the arwiki one.
gerritbot added a comment.Jun 16 2020, 11:21 PM

Change 606035 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Compute DSR info for mw:DisplaySpace

https://gerrit.wikimedia.org/r/606035

gerritbot added a project: Patch-For-Review.Jun 16 2020, 11:21 PM
gerritbot added a comment.Jun 17 2020, 7:11 PM

Change 606035 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Compute DSR info for mw:DisplaySpace

https://gerrit.wikimedia.org/r/606035

Arlolra closed this task as Resolved.Jun 17 2020, 7:47 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits