Page MenuHomePhabricator

Default button when selecting two revisions on history should be "compare selected revisions"
Closed, ResolvedPublic

Description

Author: Jack0620

Description:
After enabling RevisionDelete, in the history page "compare selected revisions" don't work under W2k/IE6 (latest IE versions unavailable for Windows 2000). Error text:
Invalid target revision.

You have either not specified a target revision(s) to perform this function, the specified revision does not exist, or you are attempting to hide the current revision.

Return to Main page.


Version: unspecified
Severity: normal

Details

Reference
bz23589

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:06 PM
bzimport set Reference to bz23589.

danny.leinad wrote:

Are you sure you clicked proper button?

It looks you didn't click button on the left "Compare selected revesions", but you clicked button on the right "Show/hide selected revisions".

tcncv_nospam wrote:

I have noticed that the default button (activated when you press enter) has changed from "Compare selected revisions" to "Del/undel selected revisions".

From the history page, I used to be able to select a pair of from/to radio buttons and press enter to display the diff page. Now the same procedure submits a revisiondelete request that results in an "Invalid target revision" error. I think such a change in behavior is dangerous. Luckily, conditions weren't right for the revisiondelete to process to completion.

Not sure if this is what Jackie encountered.

Jack0620 wrote:

I press "old" button "Compare selected revisions", but it work like pressing "Show/hide selected revision". Boxes about revision I don't touch.

Changing summary and platform because "show/hide" shouldn't be the default button as it is currently on all platforms (I suppose; it is so also with Firefox).
Perhaps this makes also actual buttons not work for some IE error.

  • Bug 26657 has been marked as a duplicate of this bug. ***

Seems to be fixed. I cannot reproduce this behaviour with modern browsers (FF 4, IE 8, Chrome 10)

It's fixed ok, but FYI it did not reproduce only on legacy browsers. I reproduced it in FF3.6 and IE8.