Maniphest T255984

Check use of global or non-global cache keys with SimpleCacheWithBagOStuff
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Lucas_Werkmeister_WMDE
	Jun 22 2020, 10:08 AM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

Since Ia47705f4eb (T245396), SimpleCacheWithBagOStuff always uses makeKey() to create a cache key. Sometimes (probably most of the time, and possibly all of the time at least for the current uses of the class), we would prefer makeGlobalKey() instead, to share the cache between wikis.

See also T255116 for the investigation that led to the creation of this task.

Related Objects

Mentioned In: T255116: Investigate coupling in cache layer (shared cache entries in WMF environment)
Mentioned Here: T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with
T255116: Investigate coupling in cache layer (shared cache entries in WMF environment)

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 22 2020, 10:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 10:08 AM

Lucas_Werkmeister_WMDE mentioned this in T255116: Investigate coupling in cache layer (shared cache entries in WMF environment).Jun 22 2020, 10:09 AM