Description

Page: https://api.wikimedia.beta.wmflabs.org/wiki/Reference/Subreference/Nested_item

Expected behavior: To mimic the style guide:

Unselected sub-subpages should have font color #54595d
Unselected sub-subpages should have the adjacent line be of color #eaecf0
On hover, unselected sub-subpages should have background color #f8f9fa

Screenshots from the style guide:

Screen Shot 2020-08-12 at 3.53.57 PM.png (446×538 px, 25 KB)

Screen Shot 2020-08-12 at 3.57.02 PM.png (590×566 px, 34 KB)

Observed behavior: Styles do not match

Screen Shot 2020-08-12 at 3.50.18 PM.png (412×550 px, 26 KB)

Screen Shot 2020-08-12 at 3.57.58 PM.png (386×488 px, 25 KB)

Details

	Subject	Repo	Branch	Lines +/-
	style: Fix font color	mediawiki/skins/WikimediaApiPortal	master	+3 -2
	styles: Fix sidebar styles	mediawiki/skins/WikimediaApiPortal	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T256793: API Portal: Design validation for WikimediaApiPortal skin

Event Timeline

apaskulin created this task.Aug 12 2020, 10:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2020, 10:59 PM

apaskulin triaged this task as Medium priority.Aug 12 2020, 10:59 PM

apaskulin mentioned this in T256793: API Portal: Design validation for WikimediaApiPortal skin.Aug 12 2020, 11:11 PM

apaskulin claimed this task.Aug 24 2020, 5:24 PM

apaskulin added a project: Platform Team Workboards (Green).

apaskulin moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.

Change 622236 had a related patch set uploaded (by Alex Paskulin; owner: Alex Paskulin):
[mediawiki/skins/WikimediaApiPortal@master] styles: Fix sidebar styles

https://gerrit.wikimedia.org/r/622236

gerritbot added a project: Patch-For-Review.Aug 24 2020, 11:43 PM

apaskulin moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Aug 24 2020, 11:44 PM

Change 622236 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] styles: Fix sidebar styles

https://gerrit.wikimedia.org/r/622236

apaskulin moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Aug 25 2020, 2:05 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2020, 2:11 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 25 2020, 3:00 AM

This seems to have fixed the main issues described in the task but also produced an issue where the unselected subpage text is now of color #54595d instead of #202122. Moving back to Doing to address this

Change 622609 had a related patch set uploaded (by Alex Paskulin; owner: Alex Paskulin):
[mediawiki/skins/WikimediaApiPortal@master] style: Fix font color

https://gerrit.wikimedia.org/r/622609

gerritbot added a project: Patch-For-Review.Aug 26 2020, 4:08 PM

apaskulin moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Aug 26 2020, 4:09 PM

Naike added a project: Platform Team Sprints Board (Sprint 2).Aug 28 2020, 9:24 AM

Change 622609 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] style: Fix font color

https://gerrit.wikimedia.org/r/622609

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2020, 10:10 PM

Verified on beta!

apaskulin closed this task as Resolved.Aug 31 2020, 5:15 PM

	F32086779: Screen Shot 2020-08-12 at 3.57.02 PM.png
	Aug 12 2020, 10:59 PM

	F32086737: Screen Shot 2020-08-12 at 3.50.18 PM.png
	Aug 12 2020, 10:59 PM

	F32086798: Screen Shot 2020-08-12 at 3.57.58 PM.png
	Aug 12 2020, 10:59 PM

	F32086723: Screen Shot 2020-08-12 at 3.53.57 PM.png
	Aug 12 2020, 10:59 PM

Fix sub-subpage styles in sidebarClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Fix sub-subpage styles in sidebar
Closed, ResolvedPublic
Actions