Page MenuHomePhabricator
Create Task
Maniphest T260733

Fix border on h2 headings
Closed, ResolvedPublic
Actions

Description

Page: https://api.wikimedia.beta.wmflabs.org/wiki/Test_page

Expected behavior: To comply with the style guide, border on h2 headings has style 3px solid #eaecf0 with padding-bottom: 2px;

Screen Shot 2020-08-18 at 1.33.12 PM.png (142×598 px, 13 KB)

Observed behavior: Border has style 1px solid #a2a9b1 with different padding-bottom

Screen Shot 2020-08-18 at 1.26.16 PM.png (164×558 px, 13 KB)

Details

SubjectRepoBranchLines +/-
style: Fix h2 bordermediawiki/skins/WikimediaApiPortalmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

apaskulin created this task.Aug 18 2020, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2020, 8:33 PM
apaskulin triaged this task as Medium priority.Aug 18 2020, 8:34 PM
apaskulin mentioned this in T256793: API Portal: Design validation for WikimediaApiPortal skin.
apaskulin claimed this task.Aug 25 2020, 12:28 AM
apaskulin added a project: Platform Team Workboards (Green).
apaskulin moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.
gerritbot added a comment.Aug 25 2020, 12:39 AM

Change 622244 had a related patch set uploaded (by Alex Paskulin; owner: Alex Paskulin):
[mediawiki/skins/WikimediaApiPortal@master] style: Fix h2 border

https://gerrit.wikimedia.org/r/622244

gerritbot added a project: Patch-For-Review.Aug 25 2020, 12:39 AM
apaskulin moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Aug 25 2020, 12:39 AM
apaskulin moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Aug 25 2020, 2:06 AM
gerritbot added a comment.Aug 25 2020, 2:07 AM

Change 622244 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] style: Fix h2 border

https://gerrit.wikimedia.org/r/622244

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2020, 2:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 25 2020, 3:00 AM
apaskulin closed this task as Resolved.Aug 26 2020, 3:42 PM
apaskulin moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.

Confirmed on beta

Naike added a project: Platform Team Sprints Board (Sprint 2).Aug 28 2020, 9:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits