Page MenuHomePhabricator

Revisit client exclusion rules for errors where file uri matches URL or no URL
Closed, ResolvedPublic

Description

For quite a few errors (over 50%) it is the case that the stack trace is non-empty but useless and the URL matches the file_uri

An example useless stack trace might look like:

at <anonymous>:1:52
at <anonymous>:1:77

or

at https://he.m.wikipedia.org/wiki/%D7%A7%D7%98%D7%92%D7%95%D7%A8%D7%99%D7%94:%D7%A4%D7%A8%D7%A9%D7%95%D7%AA_%D7%94%D7%A9%D7%91%D7%95%D7%A2:117:30

or

at <anonymous>:1:1

I think as a result we should change the logic and exclude any error in the client where the originating url matches the current location.href or is empty. The stack trace check seems unnecessary. If it's empty, it's usually also associated with a bad file uri.

Examples:

Current logic:

!obj.stackTrace && ( !obj.url || ( obj.url === location.href ) )

Proposed logic:

( !obj.url || obj.url === location.href )

Event Timeline

Change 623046 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@master] Harden client to exclude errors where file uri matches URL

https://gerrit.wikimedia.org/r/623046

Jdlrobson renamed this task from Harden client to exclude errors where file uri matches URL to Revisit client exclusion rules for errors where file uri matches URL or no URL.Aug 28 2020, 7:20 PM
Jdlrobson updated the task description. (Show Details)

Change 623046 abandoned by Jdlrobson:
[mediawiki/extensions/WikimediaEvents@master] Harden client to exclude certain errors

Reason:

https://gerrit.wikimedia.org/r/623046

Change 623046 restored by Jdlrobson:
[mediawiki/extensions/WikimediaEvents@master] Harden client to exclude certain errors

https://gerrit.wikimedia.org/r/623046

Change 623046 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] clientError: exclude more stack trace-less errors

https://gerrit.wikimedia.org/r/623046