Page MenuHomePhabricator
Create Task
Maniphest T262235

Track modification of preferences
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

We should track when users manually alter their settings via api rather than using Special:GlobalWatchlistSettings

When done using the special page, SettingsManager already tracks changes (incrementing globalwatchlist.settings.new and globalwatchlist.settings.change)

Details

SubjectRepoBranchLines +/-
Track when users manually change preferencesmediawiki/extensions/GlobalWatchlistmaster+86 -6
Customize query in gerrit

Event Timeline

DannyS712 created this task.Sep 8 2020, 1:54 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 8 2020, 1:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Low priority.Sep 8 2020, 1:54 AM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 2.
DannyS712 renamed this task from Track manual modification of preference to Track modification of preference.Sep 8 2020, 1:57 AM
DannyS712 renamed this task from Track modification of preference to Track modification of preferences.
DannyS712 updated the task description. (Show Details)
DannyS712 changed the point value for this task from 2 to 3.
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Sep 8 2020, 2:04 AM

Change 625746 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Track when users manually change preferences

https://gerrit.wikimedia.org/r/625746

gerritbot added a project: Patch-For-Review.Sep 8 2020, 2:04 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Sep 8 2020, 2:39 AM

Other than me messing around and any script-assisted conversions from user script settings to extension settings at the start this shouldn't happen much, but either way it should be tracked

gerritbot added a comment.Sep 13 2020, 5:39 PM

Change 625746 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Track when users manually change preferences

https://gerrit.wikimedia.org/r/625746

DannyS712 closed this task as Resolved.Sep 13 2020, 5:39 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 4.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 13 2020, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL