Page MenuHomePhabricator

When using revision history to view multiple edits to a page at once, it should be possible to see which edit each change corresponds to
Closed, DuplicatePublic

Description

Workflow- you visit a page where there has been dozens of edits since you last visited, including some reversions. This level of change makes it almost impossible to step through edits one by one, which is why there is the multi-edit diff feature when using wikipedia page history. It helpfully allows you to see all edits made since your own last edit. This allows you to review the changes in bulk and see if there is a particular problem with any one of them, all while skipping over changes that have been reverted or overwritten.

Unfortunately, when you click "Compare selected revisions" to view changes this way, the view shown gives you no way to determine which edit contributed to which change. This means that if you find a problem, you can't find the user that made the edit, or see their reasoning for the edit. This makes the multi-edit diff tool a lot less useful than it could be.

My requested change is to show a tooltip when you hover over specific edits in the diff view. The tooltip would show the user that made the change, the date of the change, and the justification the editor typed in when committing the change. These tooltips would only be shown when doing a diff for multiple edits (for single edits, this information is already available at the top of the page).

Event Timeline

Aklapper changed the task status from Open to Stalled.Sep 20 2020, 7:26 PM

Hi @Efbrazil, thanks for taking the time to report this! Unfortunately this Wikimedia Phabricator task lacks some information.
If you have time and can still reproduce the situation: Please add a more complete description to this task. That should be

  • a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
  • what happens after performing these steps to reproduce,
  • what you expected to happen instead,
  • a full link to a web address where the issue can be seen.

You can edit the task description by clicking Edit Task. Ideally, a good description should allow any other person to follow these steps (without having to interpret steps) and see the same results. Problems that others can reproduce can get fixed faster. Thanks again!

Efbrazil changed the task status from Stalled to Open.Sep 22 2020, 6:47 PM

Steps:

  1. Click here on PC: https://en.wikipedia.org/w/index.php?title=Climate_change&action=history
  2. Change radio button on the left to be the last edit on the page (50 edits ago)
  3. Click Compare select versions
  4. Look at first edit, see there is no information about the edit
  5. Hover mouse over edit location

Result: Nothing, there is no way to tell who made the edit or why they made the edit
Expected: Tooltip showing the the user that made the change, the date of the change, and the justification the editor typed in when committing the change

Aklapper changed the task status from Open to Stalled.EditedSep 22 2020, 7:59 PM

@Efbrazil: Thanks. At step 4 I don't know where to "Hover mouse over edit location"? See my screenshot:

Screenshot_from_2020-09-22_21-34-14.jpg (791×1 px, 327 KB)

Have you tried to expand "Browse history interactively"? That would show the tooltips that you ask for.

Efbrazil changed the task status from Stalled to Open.Sep 23 2020, 3:45 PM

Sorry for the lack of precision. By "Hover mouse over edit location" I mean the location where changes are shown. That could be highlighted text in the case of addition of text (blue highlight) or removal of text (orange highlight), or a "+" paragraph in the case of adding a paragraph, or a "-" paragraph in the case of removing a paragraph. The idea is that when your mouse is over an edit, you should be able to see information about that edit.

Browse history interactively doesn't resolve the issue as far as I can tell. It also appears to be way over-engineered and complicated. This is a simple ask that solves a basic problem.

@Efbrazil: This is not simple at all I'd say, until you present some code that proves your impression. :)
What to do if several edits have taken place at the very same location in-between the two edits that you are comparing?

https://www.mediawiki.org/wiki/Who_Wrote_That%3F might be much better suited for this, I'd say.

If there's multiple edits, you show the edit responsible for the text you see. It's like "who wrote that" except it works in history view and shows the edit responsible. If there's an exception that doesn't work, please specify it. I'm a developer, this strikes me a dead simple to get done.

Thanks for the clarification! I'm going to merge this into an older open task. I'm not sure if this would/should be implemented in the diff view or the article itself, but I guess that's stuff to sort out in that older task.

Thanks for pointing to T2639. It's true that T2639 and all the bugs listed as duplicates of it are essentially identifying the same workflow problem. That points to how important this issue is to fix.

However, T2639 and the duplicates of it are asking for very complicated features as the fix. T2639 wants to let you select locations on a page and then show you UI on who made the edit and then let you take actions on that basis. All the other duplicates are also asking for new UI changes or views that are complicated like that. Some issues with the T2639 solution and others:

  • When you want to source some text, how do you get started? Is there a magic new button you click on the page before clicking the text? How is it discoverable?
  • T2639 implies there will be commands to "annotate/blame" like github, requiring more UI and workflow changes
  • If not using history view, the feature won't work for deleted text or moved text since it doesn't appear to be targeted towards history view
  • Most of the duplicates don't work for the key workflow where you want to review a subset of changes, not all at once
  • If based on text snippets as suggested in a couple duplicates, part of a text snippet could be from one edit, part from another, it could be duplicated or have been moved, so sourcing responsibility would be hard

I'm reactivating this bug as it involves a simple, discoverable, and robust solution to the common workflow problem. That changes the cost / benefit analysis and hopefully results in the feature actually getting done. Here's the advantages of the tooltip solution outlined in this bug:

  • There is no new UI or commands, just a tooltip when you hover over changed text in multi-edit history view
  • The change allows you to see who did deletions as well as additions
  • You can use the feature to break down history into chunks, allowing you to figure out that user X added some text, then user Y moved it, the user Z deleted it, and so forth
  • There's no ambiguity like there is if you are instead searching on text or viewing an article not in history view

So could this feature ask be reevaluated on the basis of the simple, clear solution here, instead of being buried under the 5+ year old T2639? I am not sure how to say "same workflow bug yet again, but here's a very simple solution".

This feature would require computing the kind of blame map described in T2639. How to display text provenance in which UI is a trivial problem in comparison.