Page MenuHomePhabricator
Create Task
Maniphest T264211

Configure SSE Client retries and timeouts to improve reliability
Closed, ResolvedPublic
Actions

Description

As discussed in T250084 this is intended to be a quick fix alternative to T261807

The SSE Client can pass arguments through to the underlying requests library, which supports connect and read timeouts. The default behavior is *no timeout*.
https://requests.readthedocs.io/en/latest/user/advanced/#timeouts

So we should be able to configure connect and read timeouts.

We'll configure retries too.

Acceptance criteria

events keep getting added to our database without a human intervening to restart the eventstream container

Related Objects

Event Timeline

jsn.sherman created this task.Sep 30 2020, 4:18 PM
jsn.sherman moved this task from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
jsn.sherman updated the task description. (Show Details)
Samwalton9-WMF awarded a token.Sep 30 2020, 4:21 PM
jsn.sherman updated the task description. (Show Details)Sep 30 2020, 4:44 PM
jsn.sherman added a comment.Sep 30 2020, 5:04 PM

Currently testing this PR on staging
https://github.com/WikipediaLibrary/externallinks/pull/50

jsn.sherman moved this task from In Progress to Review on the The-Wikipedia-Library (Kanban) board.Oct 1 2020, 3:57 PM
jsn.sherman added a comment.Oct 1 2020, 5:06 PM

This is as ready and tested as it can be without resolving a non-production environment issue first.

Samwalton9-WMF moved this task from Review to Done on the The-Wikipedia-Library (Kanban) board.Oct 2 2020, 8:38 AM
jsn.sherman added a comment.Oct 5 2020, 12:58 PM

deployed and running strong in production for a few days now.

Samwalton9-WMF subscribed.Oct 5 2020, 1:17 PM

Could we investigate "running strong" a little? It would be great to check, for example, that we don't have any suspicious data gaps from downtime. Perhaps we do that nearer the end of the week so we have more data.

Samwalton9-WMF closed this task as Resolved.Oct 13 2020, 12:29 PM
Samwalton9-WMF mentioned this in T261806: Create script that parses and saves EventStream data into Wikilink.Mar 24 2021, 10:09 AM
Samwalton9-WMF mentioned this in T261801: Create script that reads from EventStream and saves the data into a file.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits