Mobile: Language toggle visible when no other languages available
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HerrHulaHoop
	Oct 11 2020, 6:40 AM

Description

I recently upgraded to MW 1.35 and timeless skin shows the language change dropdrown (on mobile view) even though my wiki has only 1 language. Here's a link to my wiki. Clicking on the toggle just opens a blank overlay with no options (since no other languages exist).

To summarise:

On MW 1.35, the languages switch option appears in mobile mode (bug)
On MW 1.35, the languages switch option does not appear in desktop mode (correct)
On MW 1.34, the languages switch option does not appear in desktop and mobile mode (correct)

Mobile:

Desktop:

Event Timeline

HerrHulaHoop created this task.Oct 11 2020, 6:40 AM

The languages menus are only supposed to be showing up like this when no languages are there to support tools like wikibase adding/editing links via the menu.

But... yeah, the empty menus should not be showing up when those aren't enabled; not sure what changed... (or even how it was being supported to begin with, frankly)

Change 649727 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Fix more small things

https://gerrit.wikimedia.org/r/649727

gerritbot added a project: Patch-For-Review.Dec 15 2020, 7:56 PM

Turns out something changed.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 15 2020, 9:00 PM

Thanks a lot for looking into this! Really appreciate it.

Thanks for the clear report! Very helpful, that.

	F32381204: Mobile 1_35.png
	Oct 11 2020, 6:40 AM

	F32381203: Desktop 1_35.png
	Oct 11 2020, 6:40 AM

Mobile: Language toggle visible when no other languages availableClosed, ResolvedPublicActions

Description

Event Timeline

Mobile: Language toggle visible when no other languages available
Closed, ResolvedPublic
Actions