Page MenuHomePhabricator
Create Task
Maniphest T266159

OAuth extension - remove unused $permissionManager variable from ...\src\Control\ConsumerSubmitControl.php.
Closed, ResolvedPublic
Actions

Description

Doublicated $permissionManager assignment is to be removed form processAction() method of the ...\src\Control\ConsumerSubmitControl.php class.

Details

SubjectRepoBranchLines +/-
ConsumerSubmitControl: remove unused $permissionManager variablemediawiki/extensions/OAuthmaster+0 -1
Customize query in gerrit

Event Timeline

Art.tsymbar created this task.Oct 21 2020, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2020, 4:29 PM
Art.tsymbar assigned this task to Vlad.shapik.Oct 23 2020, 9:38 AM
Vlad.shapik moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Oct 25 2020, 9:51 AM
gerritbot added a comment.Oct 25 2020, 10:00 AM

Change 636159 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OAuth@master] ConsumerSubmitControl: remove unused $permissionManager variable

https://gerrit.wikimedia.org/r/636159

gerritbot added a project: Patch-For-Review.Oct 25 2020, 10:00 AM
Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 25 2020, 10:06 AM
gerritbot added a comment.Oct 25 2020, 5:10 PM

Change 636159 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] ConsumerSubmitControl: remove unused $permissionManager variable

https://gerrit.wikimedia.org/r/636159

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 25 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 25 2020, 6:10 PM
Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Oct 25 2020, 7:47 PM
Reedy closed this task as Resolved.Oct 25 2020, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits