Page MenuHomePhabricator
Create Task
Maniphest T267801

replace assertRaises/assertWarns partial calls with context manager calls
Closed, ResolvedPublic
Actions

Description

What to change?

All occurences of

  • assertRaises
  • assertRaisesRegex
  • assertWarns
  • assertWarnsRegex

They can be found here.

Why to change?

These unittest methods were changed from partial call to context manager with the benefit of better readability and a new msg parameter which is provided with it

How to change?

replace code like

self.assertRaisesRegex(ValueError, "invalid literal for.*XYZ'$", int, 'XYZ')

with

with self.assertRaisesRegex(ValueError, "invalid literal for.*XYZ'$"):
   int('XYZ')

Documentation

https://docs.python.org/3/library/unittest.html?highlight=assertraisesregex#unittest.TestCase.assertRaises

Details

SubjectRepoBranchLines +/-
[bugfix] Fix assertRaises tests in api_tests.pypywikibot/coremaster+8 -8
Adopted use of context Manager call for assertRaises/assertRaisesRegexpywikibot/coremaster+158 -114
Used Context Manager call for assertRaises/assertRaisesRegexpywikibot/coremaster+304 -212
Adopted context manager calls for assertRaises/assertRaisesRegexpywikibot/coremaster+170 -135
Adopted use of Context Manager call for assertRaises/assertRaisesRegexpywikibot/coremaster+117 -100
[tests] Fix assertRaises tests in api_tests.pypywikibot/coremaster+3 -2
Adopted context Manager call for assertRaises in certain script(s)pywikibot/coremaster+66 -50
[IMPR] Replaced assertRaises/assertWarns partial calls with context manager callspywikibot/coremaster+46 -48
[IMPR] Replaced assertRaises/assertWarns partial calls with context manager callspywikibot/coremaster+28 -28
[IMPR] Replaced assertRaises/assertWarns partial callspywikibot/coremaster+12 -12
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Nov 12 2020, 2:49 PM
Restricted Application added a project: Pywikibot. · View Herald TranscriptNov 12 2020, 2:49 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Xqt triaged this task as Lowest priority.Nov 12 2020, 2:49 PM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)Nov 12 2020, 2:51 PM
Udoka_Ugo claimed this task.Nov 14 2020, 2:30 PM
gerritbot added a comment.Nov 19 2020, 10:47 PM

Change 642172 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls with context manager calls

https://gerrit.wikimedia.org/r/642172

gerritbot added a project: Patch-For-Review.Nov 19 2020, 10:47 PM

Change 642173 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls with context manager calls

https://gerrit.wikimedia.org/r/642173

gerritbot added a comment.Nov 19 2020, 10:51 PM

Change 642174 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls

https://gerrit.wikimedia.org/r/642174

gerritbot added a comment.Jan 16 2021, 3:54 PM

Change 642174 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls

Reason:
2 months without any change

https://gerrit.wikimedia.org/r/642174

gerritbot added a comment.Jan 16 2021, 3:54 PM

Change 642173 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls with context manager calls

Reason:
2 months without any change

https://gerrit.wikimedia.org/r/642173

gerritbot added a comment.Jan 16 2021, 3:55 PM

Change 642172 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced assertRaises/assertWarns partial calls with context manager calls

Reason:
2 months without any change

https://gerrit.wikimedia.org/r/642172

Xqt removed Udoka_Ugo as the assignee of this task.Jan 16 2021, 3:55 PM
Xqt removed a project: Patch-For-Review.
Xqt added a subscriber: Udoka_Ugo.
Homeboy_445 claimed this task.Jan 18 2021, 2:49 PM
gerritbot added a comment.Jan 20 2021, 7:35 AM

Change 657287 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Adopted context Manager call for assertRaises in certain script(s)

https://gerrit.wikimedia.org/r/657287

gerritbot added a project: Patch-For-Review.Jan 20 2021, 7:35 AM
gerritbot added a comment.Jan 22 2021, 2:45 PM

Change 657287 merged by jenkins-bot:
[pywikibot/core@master] Adopted context Manager call for assertRaises in certain script(s)

https://gerrit.wikimedia.org/r/657287

Homeboy_445 mentioned this in rPWBC07578c679ce3: Adopted context Manager call for assertRaises in certain script(s).Jan 22 2021, 2:45 PM
gerritbot added a comment.Jan 22 2021, 4:09 PM

Change 657863 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Fix assertRaises tests in api_tests.py

https://gerrit.wikimedia.org/r/657863

gerritbot added a comment.Jan 22 2021, 4:13 PM

Change 657863 merged by Xqt:
[pywikibot/core@master] [tests] Fix assertRaises tests in api_tests.py

https://gerrit.wikimedia.org/r/657863

Xqt mentioned this in rPWBC408f3277558f: [tests] Fix assertRaises tests in api_tests.py.Jan 22 2021, 4:15 PM
Xqt updated the task description. (Show Details)Jan 23 2021, 1:56 PM

I updated the search string to https://codesearch.wmcloud.org/pywikibot/?q=(%20)%7B2%2C%7Dself%5C.assert(Raises%7CWarns)(Regexp%3F)%3F&i=nope&files=&excludeFiles=&repos=

gerritbot added a comment.Jan 25 2021, 9:29 AM

Change 658222 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Adopted use of Context Manager call for assertRaises/assertRaisesRegex in certain scripts

https://gerrit.wikimedia.org/r/658222

gerritbot added a comment.Jan 26 2021, 10:50 AM

Change 658222 merged by jenkins-bot:
[pywikibot/core@master] Adopted use of Context Manager call for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/658222

Homeboy_445 mentioned this in rPWBC08f7850940bd: Adopted use of Context Manager call for assertRaises/assertRaisesRegex.Jan 26 2021, 10:55 AM
Xqt removed Homeboy_445 as the assignee of this task.Jan 29 2021, 8:43 AM
Xqt removed a project: Patch-For-Review.
Xqt added a subscriber: Homeboy_445.
gerritbot added a comment.Jan 29 2021, 1:39 PM

Change 659857 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Adopted context manager calls for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/659857

gerritbot added a project: Patch-For-Review.Jan 29 2021, 1:39 PM
gerritbot added a comment.Jan 30 2021, 2:54 PM

Change 659857 merged by jenkins-bot:
[pywikibot/core@master] Adopted context manager calls for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/659857

Homeboy_445 mentioned this in rPWBC682bef47be54: Adopted context manager calls for assertRaises/assertRaisesRegex.Jan 30 2021, 3:05 PM
gerritbot added a comment.Feb 2 2021, 5:29 PM

Change 661124 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Used Context Manager call for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/661124

gerritbot added a comment.Feb 4 2021, 10:32 AM

Change 661124 merged by jenkins-bot:
[pywikibot/core@master] Used Context Manager call for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/661124

Homeboy_445 mentioned this in rPWBC77b6904b097c: Used Context Manager call for assertRaises/assertRaisesRegex.Feb 4 2021, 10:55 AM
Xqt removed a project: Patch-For-Review.Feb 4 2021, 8:00 PM
gerritbot added a comment.Feb 7 2021, 10:51 AM

Change 662107 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Adopted use of context Manager call for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/662107

gerritbot added a project: Patch-For-Review.Feb 7 2021, 10:51 AM
Xqt assigned this task to Homeboy_445.Feb 7 2021, 2:18 PM
gerritbot added a comment.Feb 9 2021, 8:25 AM

Change 662107 merged by jenkins-bot:
[pywikibot/core@master] Adopted use of context Manager call for assertRaises/assertRaisesRegex

https://gerrit.wikimedia.org/r/662107

Homeboy_445 mentioned this in rPWBC89b250a5976b: Adopted use of context Manager call for assertRaises/assertRaisesRegex.Feb 9 2021, 9:03 AM
Xqt closed this task as Resolved.Feb 9 2021, 10:01 AM
Xqt removed a project: Patch-For-Review.

Thank you Homeboy_445!

gerritbot added a comment.Feb 22 2024, 10:04 AM

Change 1005715 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Fix assertRaises tests in api_tests.py

https://gerrit.wikimedia.org/r/1005715

gerritbot added a project: Patch-For-Review.Feb 22 2024, 10:04 AM
gerritbot added a comment.Feb 22 2024, 10:32 AM

Change 1005715 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Fix assertRaises tests in api_tests.py

https://gerrit.wikimedia.org/r/1005715

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2024, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits