Page MenuHomePhabricator
Create Task
Maniphest T269895

False positives with methods taking string|Message
Closed, ResolvedPublic
Actions

Description

Creating as placeholder, see https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/SecurityCheckPlugin/+/491257 for the description

Details

SubjectRepoBranchLines +/-
Avoid false positives with polymorphic methods taking string|Messagemediawiki/tools/phan/SecurityCheckPluginmaster+178 -0
Document HttpError to help taint-checkmediawiki/coremaster+12 -6
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Dec 10 2020, 10:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 10:12 PM
gerritbot added a comment.Dec 11 2020, 11:07 PM

Change 648368 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Document HttpError to help taint-check

https://gerrit.wikimedia.org/r/648368

gerritbot added a project: Patch-For-Review.Dec 11 2020, 11:07 PM
gerritbot added a comment.Dec 11 2020, 11:21 PM

Change 491257 had a related patch set uploaded (by Daimona Eaytoy; owner: Brian Wolff):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Avoid false positives with polymorphic methods taking string|Message

https://gerrit.wikimedia.org/r/491257

gerritbot added a comment.Dec 12 2020, 12:56 AM

Change 648368 merged by jenkins-bot:
[mediawiki/core@master] Document HttpError to help taint-check

https://gerrit.wikimedia.org/r/648368

gerritbot added a comment.Dec 12 2020, 1:12 AM

Change 491257 merged by jenkins-bot:
[mediawiki/tools/phan/SecurityCheckPlugin@master] Avoid false positives with polymorphic methods taking string|Message

https://gerrit.wikimedia.org/r/491257

Daimona closed this task as Resolved.Dec 12 2020, 1:14 AM
Daimona claimed this task.
Daimona removed a project: Patch-For-Review.
Daimona mentioned this in rMTPS1a8cc488bcc8: Avoid false positives with polymorphic methods taking string|Message.Dec 12 2020, 1:17 AM
Daimona mentioned this in T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.Dec 12 2020, 1:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL