Page MenuHomePhabricator
Create Task
Maniphest T270264

Implement Popconfirm while logging out from the tool
Closed, ResolvedPublic
Actions

Description

VideoCutTool is a tool to trim, crop, rotate on-the-fly videos in Wikimedia Commons and can be found at https://videocuttool.wmflabs.org/

Task:

  • Learn about VideoCutTool from Commons: VideoCutTool
  • Currently on clicking the logout button users can get logged out without asking for popup confirmation, It's always good to use confirm pop-up and logout, So the main task is to use react antd's Popconfirm module and implement the confirm logout option in the tool.

Code repos:

If you need any help, please feel free to comment here, happy to help you!

Details

SubjectRepoBranchLines +/-
Implement logout confirm popuplabs/tools/VideoCutToolmaster+14 -7
Customize query in gerrit

Event Timeline

Gopavasanth created this task.Dec 16 2020, 11:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2020, 11:15 AM
gerritbot added a comment.Dec 18 2020, 4:20 PM

Change 650525 had a related patch set uploaded (by Tobi 406; owner: Tobi 406):
[labs/tools/VideoCutTool@master] Implement logout confirm popup

https://gerrit.wikimedia.org/r/650525

gerritbot added a project: Patch-For-Review.Dec 18 2020, 4:20 PM
Tobi_406 claimed this task.Dec 18 2020, 4:25 PM
Tobi_406 subscribed.

Just thought I'll take this up, hope that's ok

Had some problems logging in (I think I set up OAuth wrong), but I just added a user cookie with an object ({"username": "test"}) and that seemed to work.

Tobi_406 updated the task description. (Show Details)Dec 18 2020, 4:25 PM
gerritbot added a comment.Dec 18 2020, 5:06 PM

Change 650525 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Implement logout confirm popup

https://gerrit.wikimedia.org/r/650525

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2020, 5:10 PM
Gopavasanth added a comment.Dec 18 2020, 5:10 PM

Hey @Tobi_406, Thanks for your patch!

Had some problems logging in (I think I set up OAuth wrong), but I just added a user cookie with an object ({"username": "test"}) and that seemed to work.

Oh yeah, You can solve this by changing the env variable backend_url: "https://videocuttool.wmflabs.org/video-cut-tool-back-end" from localhost as you don't have OAuth tokens :)

Gopavasanth closed this task as Resolved.Dec 18 2020, 5:10 PM
Gopavasanth moved this task from Incoming to Done on the VideoCutTool board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL