@Shreyasminocha There are few minor things encountered after testing your patch,

I guess here the blue node might represent the compared revision is in the next phase? @WMDE-Fisch what do you think?

Yeah, I too agree with the @Charlie_WMDE suggestions.

@Puneethchanda This is the Google Code-in Task, So only the students from the Google-Code-in-2018 Should work on it, so I'm Removing you from the assign, Sorry Hope you understand :-)

So this is Done for now, @D3r1ck01 can you delete this task in GCI website?

@Jayprakash12345 thanks for updating the task :-)

@Aklapper Thanks for updating the description and creating more such tasks in GCI site.

@D3r1ck01, @Aklapper So as per the request in https://phabricator.wikimedia.org/T189687#4691727 to create such tasks for GCI-18, There are many extensions to be done, So do we have any specific extensions to fix in this GCI-18 ?

We can't close this ticket as only the GCI task is completed but there are lot more occurrences of http in many extensions. So I am again opening this task.

URLs above would require a student to write 1 patch, some URLs would require a student to write dozens of patches. This task needs better slicing for Google-Code-in-2018.)

Yes, you are right @Aklapper Here Obsolete refers to Outdated.

@RazeSoldier Yes, we need to change including the comments.

@Zoranzoki21 Thanks for that you may be right, but some people might go wrong if they didn't test and submit the patch, So it's always preferred to read extension documentation, Install, Code, recheck and then submit the patch.

@Aklapper Thank you, I updated the task description and now its easier to find the code base and start working :-)

Imported in Google-Code-in-2018 https://codein.withgoogle.com/dashboard/tasks/5177614659485696/

Imported in Google-Code-in-2018 https://codein.withgoogle.com/dashboard/tasks/4710076196585472/

Hi, did anyone test the latest patch? :)

@Gopavasanth and @D3r1ck01 will Mentor in Google-Code-in-2018

Mentors @D3r1ck01 and @Gopavasanth in Google-Code-in-2018

This task is imported in Google-Code-in-2018 https://codein.withgoogle.com/dashboard/tasks/6010343974240256/

Before

@Gopavasanth, I see you've imported as: https://codein.withgoogle.com/tasks/5661677002424320/ on GCI right and added yourself as mentor?

Yes this is Good tasks for Google-Code-in-2018

@D3r1ck01 I will mentor with this Task :-) in Google-Code-in-2018

Adding Google-Code-in-2018 I and @Addshore will mentor this.

Yea, I am happy to mentor this in Google-Code-in-2018

It's hard to describe the current behavior of the patch. It feels somewhat unpredictable.

I made a few changes and pushed *patchset-15*, Now it's working good without any misbehavior.

For edits with exactly 50 bytes it fails (I think because it tries to calculate Math.log( 0 )).

So @thiemowmde to fix this we can modify logic from diffSize > -50 && diffSize < 50 to diffSize >= -50 && diffSize <= 50 ? That's the straightway to fix this.

Tag is already included in this task

This Tag came after mentioning in T201491#4586233

I think we should add Google-Code-in-2018 tag to T201491#4564886 and I will mentor this task @srishakatux ?

The ticket tittle looks

Use default framed buttons in the RevisionSlider expand/collaps bar

As discussed in the ticket T201673#4496650 RevisionSlider currently doesn't have collaps icon.