Page MenuHomePhabricator

Restructure Button.vue classes to match buttons' variants and types
Closed, ResolvedPublic

Description

The classes in Button.vue styles should be renamed and structured to reflect the button component's variants, types and states:

.wikit-Button

  • normal (&disabled) --neutral (&hover, focus, active)
  • primary (&disabled) --progressive (&hover, focus, active) --destructive (&hover, focus, active)
  • quiet (&disabled) --neutral (&hover, focus, active) --progressive (&hover, focus, active) --destructive (&hover, focus, active)

We should create separate props for type and variant, matching the new classes.

Notes:

  • Primary buttons should have their own separate page in Storybook
  • The restructuring should be done as part of the new WiKit release (2.0)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sarai-WMDE renamed this task from Restructure Button.vue classes to match button component variants and types to Restructure Button.vue classes to match buttons' variants and types.Dec 17 2020, 3:18 PM