Page MenuHomePhabricator
Create Task
Maniphest T270849

mw-fr-revisiontag element uses non-core "nomobile" class, so default MediaWiki skins still display it on mobile
Closed, DeclinedPublicFeature
Actions

Description

The element "mw-fr-revisiontag" at the top of the page uses the class "nomobile" to apparently hide it on mobile. This class is not defined at least in any of the default skins shipped with Mediawiki.

If you are viewing an unreviewed page on mobile, the content is interrupted by this element because the element is shown because the class has no effect.

I propose to use a method that is available in the default skins or the custom css of the extension to ensure the element is hidden on mobile.

Event Timeline

Tkinkhorst created this task.Dec 27 2020, 10:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 27 2020, 10:34 AM
Kizule added a project: MediaWiki-extensions-FlaggedRevs.Dec 27 2020, 12:45 PM
Aklapper changed the subtype of this task from "Bug Report" to "Feature Request".Dec 27 2020, 12:54 PM

@Tkinkhorst: How is "on mobile" defined? How exactly would you detect this anyway?

Aklapper renamed this task from mw-fr-revisiontag element uses nonexistent nomobile class to mw-fr-revisiontag element uses nonexistent "nomobile" class, so it will still be displayed on mobile with default MediaWiki skins.Jan 11 2021, 10:47 AM
Wugapodes moved this task from Backlog to Feature requests on the MediaWiki-extensions-FlaggedRevs board.Mar 16 2021, 9:09 PM
Wugapodes renamed this task from mw-fr-revisiontag element uses nonexistent "nomobile" class, so it will still be displayed on mobile with default MediaWiki skins to mw-fr-revisiontag element uses non-core "nomobile" class, so default MediaWiki skins still display it on mobile.Mar 16 2021, 9:30 PM
Wugapodes triaged this task as Low priority.
Wugapodes added a project: Vector (legacy skin).
Jdlrobson changed the task status from Open to Stalled.Mar 17 2021, 6:33 PM
Jdlrobson raised the priority of this task from Low to Needs Triage.
Jdlrobson subscribed.

I don't know what this task is about as written. Please can you provide a URL and possibly a screenshot so we can triage it effectively?

Jdlrobson closed this task as Declined.Mar 25 2021, 5:12 PM

The nomobile class has nothing to do with vector or mediawiki core. It is an on-wiki construction so the fix is likely on wiki.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL