Page MenuHomePhabricator
Create Task
Maniphest T273536

jsduck: <input> not escaped in documentation for DateTimeInputWidget
Closed, ResolvedPublic
Actions

Description

A text box is shown in the JSDuck documentation for mw.widgets.datetime.DateTimeInputWidget. This seems to be because <input> is not escaped in the source.

Details

SubjectRepoBranchLines +/-
Escape <input> in DateTimeInputWidget documentationmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Nardog created this task.Feb 1 2021, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2021, 9:18 PM
Kghbln subscribed.Feb 2 2021, 3:16 PM

Unrelated to the Widgets extension.

Kghbln removed a project: MediaWiki-extensions-Widgets.Feb 2 2021, 3:16 PM
Aklapper renamed this task from <input> not escaped in documentation for DateTimeInputWidget to jsduck: <input> not escaped in documentation for DateTimeInputWidget.Feb 10 2021, 11:19 AM

Wondering whether https://phabricator.wikimedia.org/diffusion/MW/browse/master/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js needs some escaping / editing. Or if JSDuck welcomes a bug report at https://github.com/senchalabs/jsduck/issues .

Screenshot from 2021-02-10 12-17-05.png (442×1 px, 133 KB)

Nardog added a comment.Feb 10 2021, 11:43 AM

@Aklapper I assume backticks (i.e.`<input>`) will do. Compare the section for simulateLabelClick() and the corresponding source.

Kghbln unsubscribed.Feb 10 2021, 11:44 AM
Aklapper added a project: good first task.Mar 8 2021, 7:56 AM
gerritbot added a comment.Mar 8 2021, 9:04 PM

Change 669978 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Nardog):
[mediawiki/core@master] Escape <input> in DateTimeInputWidget documentation

https://gerrit.wikimedia.org/r/669978

gerritbot added a project: Patch-For-Review.Mar 8 2021, 9:04 PM
gerritbot added a comment.Mar 8 2021, 11:15 PM

Change 669978 merged by jenkins-bot:
[mediawiki/core@master] Escape <input> in DateTimeInputWidget documentation

https://gerrit.wikimedia.org/r/669978

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 12:00 AM
Nardog closed this task as Resolved.Mar 9 2021, 12:01 AM
Nardog claimed this task.
Nardog removed projects: Patch-For-Review, good first task.Mar 9 2021, 12:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL