Page MenuHomePhabricator

Investigate potential bug which is waitlisting a resource which shouldn't be waitlisted [2hr]
Closed, ResolvedPublicSpike

Description

Newspapers.com has, on a couple of occasions, been waitlisted seemingly without anyone on staff (or the coordinator) setting it as waitlisted. There might be a bug with the automatic-waitlisting logic which should only set waitlisted when we've run out of accounts for a partner. Newspapers.com has no account cap so shouldn't be getting waitlisted.

We haven't confirmed exactly how/when this is happening, so this is a spike to figure out what the actual problem is, if it's in the code. It would be worth reading through both the individual and batch edit views to see if we might be triggering the no_more_accounts signal in cases where we don't expect to.

Event Timeline

On the staging tool I've tried changing the status of applications through both the individual and batch workflows and haven't been able to reproduce Newspapers.com randomly becoming waitlisted.

Samwalton9 renamed this task from Fix bug which is waitlisting a resource which shouldn't be waitlisted to Investigate potential which is waitlisting a resource which shouldn't be waitlisted [2hr].Feb 2 2021, 4:21 PM
Samwalton9 added a project: Spike.
Samwalton9 updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptFeb 2 2021, 4:21 PM
Samwalton9 renamed this task from Investigate potential which is waitlisting a resource which shouldn't be waitlisted [2hr] to Investigate potential bug which is waitlisting a resource which shouldn't be waitlisted [2hr].Feb 2 2021, 4:22 PM

Did you make any progress on this @Scardenasmolinar? Just noticing it's been here for more than a day :)

I haven't! Got distracted by other tasks, but I'll have this done by EOD today.

I also was not able to replicate this error in my local environment. It would be helpful to understand the steps the user took to see if we can replicate the bug next time it happens.

Unfortunately the extent of the reproduction steps is "look at Newspapers.com and realise it's been waitlisted", so I guess we'll close this out for now. It doesn't seem to have happened since the initial report. Thanks for investigating!