Page MenuHomePhabricator
Create Task
Maniphest T275666

links on action=credits are not preloaded and results in many database queries to get blue color and gender state
Open, Needs TriagePublic
Actions

Description

The action action=credits is linking user pages without preloading the titles into the LinkCache, which results in one query (or two on wiki with gender support) for each link in that list (except ips or external user names)

Details

SubjectRepoBranchLines +/-
Add LinkBatch to action=creditsmediawiki/coremaster+13 -0
Customize query in gerrit

Event Timeline

Umherirrender created this task.Feb 24 2021, 6:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2021, 6:28 PM
gerritbot added a comment.Feb 24 2021, 6:28 PM

Change 620788 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Add LinkBatch to action=credits

https://gerrit.wikimedia.org/r/620788

gerritbot added a project: Patch-For-Review.Feb 24 2021, 6:28 PM
gerritbot added a comment.Mar 24 2021, 6:29 PM

Change 620788 abandoned by Umherirrender:
[mediawiki/core@master] Add LinkBatch to action=credits

Reason:

https://gerrit.wikimedia.org/r/620788

Umherirrender removed a project: Patch-For-Review.Mar 24 2021, 6:30 PM
Umherirrender unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL