Ask the user to save changes before leaving page when PagelistWidget has changes
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Soda
	Mar 18 2021, 7:07 PM

Description

Currently, the Pagelist Widget doesn't do anything when a user closes the tab/navigates away while having unsaved changes.

We should trigger browser's default unsaved changes dialog when a user navigates away/closes the tab while still having un-inserted changes in the Pagelist Widget

P.S: We should use MediaWiki's mw.confirmCloseWindow() api to implement this.

Documentation

Tutorial on setting up and working with Gerrit (Gerrit is Wikimedia's code review platform)
Files that needs to be modified: PagelistInputWidget.VisualDialogModel.js and PagelistInputWidget.WikitextDialogModel.js
OOUI (the framework used to build the PagelistWidget)
Documentation for mw.confirmCloseWindow()

Details

	Subject	Repo	Branch	Lines +/-
	PagelistWidget: Trigger browser's unsaved changes dialog on page/tab close	mediawiki/extensions/ProofreadPage	master	+4 -0

Customize query in gerrit

Event Timeline

Soda created this task.Mar 18 2021, 7:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2021, 7:07 PM

For context, in both of the models, the method updateCachedDataFromMainModel() is used to initialize the model with data, when the dialog is opened and unloadCachedData() is called when the dialog is closed.

Soda updated the task description. (Show Details)Mar 18 2021, 7:15 PM

CipherGirl claimed this task.Mar 19 2021, 12:15 PM

Iamumangg claimed this task.Mar 25 2021, 5:28 PM

Iamumangg added a subscriber: CipherGirl.

@Iamumangg: I don't think that removing someone else as an assignee without consent is common; did CipherGirl agree to this beforehand?

Hey it's okay to claim, I'm no longer looking into this.

Inductiveload moved this task from Backlog to Pagelist Widget on the ProofreadPage board.Sep 20 2021, 6:48 AM

hussamsi subscribed.Oct 20 2022, 8:10 AM

@Iamumangg: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Tonymetz subscribed.Apr 29 2024, 6:42 PM

Change #1053788 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/ProofreadPage@master] PagelistWidget: Trigger browser's unsaved changes dialog on page/tab close

https://gerrit.wikimedia.org/r/1053788

gerritbot added a project: Patch-For-Review.Jul 11 2024, 9:14 PM

Ask the user to save changes before leaving page when PagelistWidget has changesOpen, Needs TriagePublicActions

Description

Documentation

Details

Event Timeline

Ask the user to save changes before leaving page when PagelistWidget has changes
Open, Needs TriagePublic
Actions