Page MenuHomePhabricator
Create Task
Maniphest T277791

Ask the user to save changes before leaving page when PagelistWidget has changes
Closed, ResolvedPublic
Actions

Description

Currently, the Pagelist Widget doesn't do anything when a user closes the tab/navigates away while having unsaved changes.

We should trigger browser's default unsaved changes dialog when a user navigates away/closes the tab while still having un-inserted changes in the Pagelist Widget

P.S: We should use MediaWiki's mw.confirmCloseWindow() api to implement this.

Documentation

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
PagelistWidget: Trigger browser's unsaved changes dialog on page/tab closemediawiki/extensions/ProofreadPagemaster+4 -0
PagelistWidget: warn on unsaved changes before window closemediawiki/extensions/ProofreadPagemaster+59 -0
Customize query in gerrit

Event Timeline

Soda created this task.Mar 18 2021, 7:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2021, 7:07 PM
Soda added a comment.EditedMar 18 2021, 7:14 PM

For context, in both of the models, the method updateCachedDataFromMainModel() is used to initialize the model with data, when the dialog is opened and unloadCachedData() is called when the dialog is closed.

Soda updated the task description. (Show Details)Mar 18 2021, 7:15 PM
CipherGirl claimed this task.Mar 19 2021, 12:15 PM
Iamumangg claimed this task.Mar 25 2021, 5:28 PM
Iamumangg added a subscriber: CipherGirl.
Aklapper added a comment.Apr 5 2021, 11:02 AM

@Iamumangg: I don't think that removing someone else as an assignee without consent is common; did CipherGirl agree to this beforehand?

CipherGirl added a comment.Apr 5 2021, 11:30 AM

Hey it's okay to claim, I'm no longer looking into this.

Inductiveload moved this task from Backlog to Pagelist Widget on the ProofreadPage board.Sep 20 2021, 6:48 AM
hussamsi subscribed.Oct 20 2022, 8:10 AM
Aklapper removed Iamumangg as the assignee of this task.Nov 21 2023, 8:16 AM
Aklapper added a subscriber: Iamumangg.

@Iamumangg: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Tonymetz subscribed.Apr 29 2024, 6:42 PM
gerritbot added a comment.Jul 11 2024, 9:14 PM

Change #1053788 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/ProofreadPage@master] PagelistWidget: Trigger browser's unsaved changes dialog on page/tab close

https://gerrit.wikimedia.org/r/1053788

gerritbot added a project: Patch-For-Review.Jul 11 2024, 9:14 PM
Somyaya subscribed.Oct 4 2025, 1:49 PM

Hi, I’m new and would like to work on this task as my first contribution. Can I be assigned?

Aklapper added a comment.EditedOct 4 2025, 2:08 PM

@Somyaya: Welcome! Please first read the "New Developers" page on mediawiki.org and its Communication Tips section. Also see above that there is already a patch which needs rework. Thanks!

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jan 11 2026, 4:35 PM
Codeurluce subscribed.Jan 12 2026, 8:35 PM

I’m working on this task and have implemented the unload warning using mw.confirmCloseWindow() in both VisualDialogModel.js and WikitextDialogModel.js.
A patch will be submitted shortly via Gerrit.

Codeurluce claimed this task.Jan 12 2026, 8:35 PM
gerritbot added a comment.Jan 13 2026, 1:42 PM

Change #1226248 had a related patch set uploaded (by Codeurluce; author: Codeurluce):

[mediawiki/extensions/ProofreadPage@master] PagelistWidget: warn on unsaved changes before window close

https://gerrit.wikimedia.org/r/1226248

gerritbot added a project: Patch-For-Review.Jan 13 2026, 1:42 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJan 13 2026, 1:42 PM
Codeurluce added a comment.Jan 13 2026, 1:54 PM

Patch submitted: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1226248

Bugreporter2 awarded a token.Jan 14 2026, 1:06 AM
Codeurluce added a comment.Jan 15 2026, 12:57 PM
This comment was removed by Codeurluce.
Soda closed this task as Resolved.Jan 15 2026, 3:15 PM
gerritbot added a comment.Jan 15 2026, 3:38 PM

Change #1226248 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] PagelistWidget: warn on unsaved changes before window close

https://gerrit.wikimedia.org/r/1226248

gerritbot added a comment.Jan 16 2026, 7:41 AM

Change #1053788 abandoned by Sohom Datta:

[mediawiki/extensions/ProofreadPage@master] PagelistWidget: Trigger browser's unsaved changes dialog on page/tab close

Reason:

alternative fix merged

https://gerrit.wikimedia.org/r/1053788

Pppery removed a project: Patch-For-Review.Mon, Jan 19, 5:43 AM
Tonymetz unsubscribed.Wed, Jan 28, 12:31 AM
Tonymetz subscribed.
Tonymetz unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits