Page MenuHomePhabricator

Global preferences does not properly indent the "Use Legacy Vector" option
Closed, ResolvedPublic

Description

The "Use Legacy Vector" is not indented properly, all the other options have a padding-left of 7%. The "Use Legacy Vector" options has the class mw-htmlform-field-Vector\HTMLForm\Fields\HTMLLegacySkinVersionField, which does not match the rule that adds the padding, which matches something like mw-htmlform-field-HTMLCheckField. Since the rule seems to match every class that starts with .mw-htmlform-field- and is really long, a rule like [class^="mw-htmlform-field-"] might be better to use.

Here how it currently looks:

image.png (370×314 px, 14 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 673829 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/extensions/GlobalPreferences@master] Apply padding to all HTMLForm fields

https://gerrit.wikimedia.org/r/673829

The patch fixes that issue, but causes a new problem where some fields seem to get a double indent:

image.png (2×3 px, 398 KB)

image.png (2×3 px, 293 KB)

They have the CSS class mw-htmlform-field-autoinfuse on a nested element, which matches your selector. I think this class is poorly named, I'll submit a patch to rename it and avoid this problem.

Change 699537 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention

https://gerrit.wikimedia.org/r/699537

Change 699537 merged by jenkins-bot:

[mediawiki/core@master] Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention

https://gerrit.wikimedia.org/r/699537

Change 673829 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Apply padding to all HTMLForm fields

https://gerrit.wikimedia.org/r/673829

matmarex assigned this task to BrandonXLF.

Thanks for the patch!