Page MenuHomePhabricator

SF loads SMW Javascripts even if loaded already
Closed, ResolvedPublic

Description

SF loads Javascripts and styles from the SMW extension without caring about whether or not they are loaded by SMW. This can lead to multiple copies of a script being loaded, which can cause errors.

This happens on the above URL: the result table at the top features two copies of sort buttons. This is because of the form input further below which loads the SMW script. This is additionally strange since the script is not needed for SF at all. For best compatibility, SMW extensions should use the resource loading mechanism in ./includes/SMW_Outputs.php which is now also compatible with the new ResourceLoader. Even if ResourceLoader is not available yet, the mechanism will avoid duplicates.


Version: unspecified
Severity: normal
URL: http://semantic-mediawiki.org/w/index.php?title=Wiki_of_the_Month&oldid=4825

Details

Reference
bz25884

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz25884.

This is now fixed in SVN; thanks for the bug report.