Add `font-size-base` and `line-height` specific form components variables
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Apr 6 2021, 9:00 PM

Description

As already in place by a few skins like Vector (legacy skin) and needed by task like T277365.

font-size-base is one of the pivotal points for every skin as some skins might (rightfully) choose to use it for interface calculations.

line-heights are necessary for typographic reasons, but also for constructing the correct box sizes in current OOUI/mediawiki.ui based Vector/MF elements while enabling user-preference text sizing overrides.

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.42.0	mediawiki/core	master	+356 -404
mediawiki.less: Add `font-size-base` and `line-height-*` vars	mediawiki/core	master	+15 -0
[DEPRECATING CHANGE] Rename `line-height-base` to `line-height-label`	oojs/ui	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned Here: T277365: mw-ui-button in wikitext causes text to be vertically misaligned

Event Timeline

Volker_E created this task.Apr 6 2021, 9:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2021, 9:00 PM

Change 677366 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.less: Add `font-size-base` and `line-height-*` vars

https://gerrit.wikimedia.org/r/677366

gerritbot added a project: Patch-For-Review.Apr 6 2021, 9:06 PM

Change 677367 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] [DEPRECATING CHANGE] Rename `line-height-base` to `line-height-label`

https://gerrit.wikimedia.org/r/677367

Change 677367 merged by jenkins-bot:

[oojs/ui@master] [DEPRECATING CHANGE] Rename `line-height-base` to `line-height-label`

https://gerrit.wikimedia.org/r/677367

Change 677366 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.less: Add `font-size-base` and `line-height-*` vars

https://gerrit.wikimedia.org/r/677366

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2021, 4:10 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 13 2021, 5:00 AM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Apr 14 2021, 10:45 PM

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 15 2021, 5:25 PM

@Volker_E think that's everything.

Change 713803 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

gerritbot added a project: Patch-For-Review.Aug 19 2021, 6:58 AM

Change 713803 merged by jenkins-bot: