Page MenuHomePhabricator

Add `font-size-base` and `line-height` specific form components variables
Closed, ResolvedPublic

Description

As already in place by a few skins like Vector and needed by task like T277365.

font-size-base is one of the pivotal points for every skin as some skins might (rightfully) choose to use it for interface calculations.

line-heights are necessary for typographic reasons, but also for constructing the correct box sizes in current OOUI/mediawiki.ui based Vector/MF elements while enabling user-preference text sizing overrides.

Event Timeline

Change 677366 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.less: Add `font-size-base` and `line-height-*` vars

https://gerrit.wikimedia.org/r/677366

Change 677367 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] [DEPRECATING CHANGE] Rename `line-height-base` to `line-height-label`

https://gerrit.wikimedia.org/r/677367

Change 677367 merged by jenkins-bot:

[oojs/ui@master] [DEPRECATING CHANGE] Rename `line-height-base` to `line-height-label`

https://gerrit.wikimedia.org/r/677367

Change 677366 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.less: Add `font-size-base` and `line-height-*` vars

https://gerrit.wikimedia.org/r/677366

Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdlrobson.

@Volker_E think that's everything.