Page MenuHomePhabricator

Horizon does not allow sorting tables anymore
Closed, ResolvedPublic

Description

Before the recent Horizon update I could click on table headers and it would sort the table by that column, after the update I can't do that anymore. Not sure if related, but the JavaScript console is full or errors like Uncaught TypeError: jQuery.event.addProp is not a function.

Event Timeline

Change 678297 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] codfw1dev horizon: temporarily roll back release version to test T279699

https://gerrit.wikimedia.org/r/678297

Change 678297 merged by Andrew Bogott:

[operations/puppet@production] codfw1dev horizon: temporarily roll back release version to test T279699

https://gerrit.wikimedia.org/r/678297

Change 678317 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/wheels@main] Downgrade XStatic_JQuery_Migrate wheel

https://gerrit.wikimedia.org/r/678317

Change 678317 merged by Andrew Bogott:

[openstack/horizon/wheels@main] Downgrade XStatic_JQuery_Migrate wheel

https://gerrit.wikimedia.org/r/678317

Change 678318 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/deploy@main] Downgrade XStatic_JQuery_Migrate wheel

https://gerrit.wikimedia.org/r/678318

Change 678318 merged by Andrew Bogott:

[openstack/horizon/deploy@main] Downgrade XStatic_JQuery_Migrate wheel

https://gerrit.wikimedia.org/r/678318

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:08:24Z] <andrew@deploy1002> Started deploy [horizon/deploy@ee1be56]: cloudweb2001-dev deploy partial fix for T279699

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:08:35Z] <andrew@deploy1002> Finished deploy [horizon/deploy@ee1be56]: cloudweb2001-dev deploy partial fix for T279699 (duration: 00m 11s)

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:08:44Z] <andrew@deploy1002> Started deploy [horizon/deploy@ee1be56]: cloudweb2001-dev deploy partial fix for T279699

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:11:05Z] <andrew@deploy1002> Finished deploy [horizon/deploy@ee1be56]: cloudweb2001-dev deploy partial fix for T279699 (duration: 02m 21s)

@Majavah, you were right that the 'jQuery.event.addProp is not a function' error was the clue to the problem. The attached (downgrade) patch resolves the issue; I'll deploy to prod in a moment.

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:17:12Z] <andrew@deploy1002> Started deploy [horizon/deploy@ee1be56]: fix for T279699

Mentioned in SAL (#wikimedia-operations) [2021-04-10T14:21:24Z] <andrew@deploy1002> Finished deploy [horizon/deploy@ee1be56]: fix for T279699 (duration: 04m 12s)

Thanks @Majavah !