Maniphest T280355

Screenshots for both passing and failing tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	zeljkofilipin
	Apr 16 2021, 1:00 PM

Tags

Referenced Files

None

Subscribers

Description

There is code in wdio.conf.js to only take screenshots of failed tests.

P15388 wdio.conf.js

1	exports.config = {
2	afterTest: function ( test ) {
3	// if test passed, ignore, else take and save screenshot
4	if ( test.passed ) {
5	return;
6	}
7	// save screenshot
8	const screenshotfile = filePath( test, logPath, 'png' );
9	browser.saveScreenshot( screenshotfile );
10	console.log( '\n\tScreenshot location:', screenshotfile, '\n' );
11	}
12	};

For a while now, test.passed is returning undefined, so screenshots are taken for both passing and failing tests. The change probably happened when we upgraded webdriverio to v5 or v6, but nobody noticed it.

I actually like the current behavior. We take videos for both passing and failing tests, so it makes sense to take screenshots too. Both screenshots and videos are small files. (The biggest screenshot is 539 KB, the biggest video is 21 KB.)

If we insist on only taking screenshots for failed tests, this is how to do it. (According to Testrunner Configuration.) The only change is in lines 2 and 4.

P15389 wdio.conf.js

1	exports.config = {
2	afterTest: function ( test, context, { passed } ) {
3	// if test passed, ignore, else take and save screenshot
4	if ( passed ) {
5	return;
6	}
7	// save screenshot
8	const screenshotfile = filePath( test, logPath, 'png' );
9	browser.saveScreenshot( screenshotfile );
10	console.log( '\n\tScreenshot location:', screenshotfile, '\n' );
11	}
12	};

Details

	Subject	Repo	Branch	Lines +/-
	selenium: Fix `ReferenceError: test is not defined`	mediawiki/core	master	+6 -2
	selenium: Explicitly make screenshots for passing and failing tests	mediawiki/core	master	+5 -10

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T210726 Selenium framework cleanup
		Resolved		zeljkofilipin	T280355 Screenshots for both passing and failing tests

Event Timeline

zeljkofilipin created this task.Apr 16 2021, 1:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2021, 1:00 PM

zeljkofilipin triaged this task as Medium priority.Apr 16 2021, 1:00 PM

zeljkofilipin added a parent task: T210726: Selenium framework cleanup.

zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.

zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.

zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.

zeljkofilipin updated the task description. (Show Details)Apr 16 2021, 1:07 PM

zeljkofilipin updated the task description. (Show Details)

zeljkofilipin updated the task description. (Show Details)Apr 16 2021, 1:10 PM

zeljkofilipin updated the task description. (Show Details)Apr 16 2021, 1:12 PM

Change 680330 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Screenshots for passing and failing tests

https://gerrit.wikimedia.org/r/680330

gerritbot added a project: Patch-For-Review.Apr 16 2021, 1:36 PM

zeljkofilipin removed zeljkofilipin as the assignee of this task.Apr 16 2021, 1:42 PM

zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.

Change 680330 merged by jenkins-bot:

[mediawiki/core@master] selenium: Explicitly make screenshots for passing and failing tests

https://gerrit.wikimedia.org/r/680330

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 16 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 6:10 PM

Change 680401 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Fix `ReferenceError: test is not defined`

https://gerrit.wikimedia.org/r/680401

gerritbot added a project: Patch-For-Review.Apr 16 2021, 6:11 PM

Change 680401 merged by jenkins-bot:

[mediawiki/core@master] selenium: Fix `ReferenceError: test is not defined`

https://gerrit.wikimedia.org/r/680401

Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 8:11 PM

zeljkofilipin closed this task as Resolved.Apr 19 2021, 10:52 AM

zeljkofilipin claimed this task.