Maniphest T280436

Migrate Toolforge admission webhooks to use the admissionregistration.k8s.io/v1 API
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	taavi
	Apr 17 2021, 8:55 AM

Tags

Referenced Files

None

Subscribers

Tokens

"Cup of Joe" token, awarded by Bstorm.

Description

Kubernetes 1.16 introduced the admissionregistration.k8s.io/v1 API to replace v1beta1. We need to update our webhooks before Kubernetes 1.22.

Details

	Subject	Repo	Branch	Lines +/-
	Use Admission review v1 API	labs/tools/registry-admission-webhook	master	+135 -26
	Use Admission review v1 API	cloud/toolforge/ingress-admission-controller	master	+38 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T362869 Upgrade Toolforge to Uwubernetes
		Open		None	T362868 [infra,k8s] pgrade Toolforge Kubernetes to version 1.29
		Open		None	T362867 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.28
		Open		None	T359641 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.27
		Open		None	T327025 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.26
		Open		None	T316107 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.25
		Resolved		aborrero	T307651 Upgrade Toolforge Kubernetes to version 1.24
		Resolved		taavi	T298005 Upgrade Toolforge Kubernetes to version 1.23
		Resolved		taavi	T286856 Upgrade Toolforge Kubernetes to latest 1.22
		Resolved		taavi	T280436 Migrate Toolforge admission webhooks to use the admissionregistration.k8s.io/v1 API

Event Timeline

taavi triaged this task as Medium priority.Apr 17 2021, 8:55 AM

taavi created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2021, 8:55 AM

Change 680650 had a related patch set uploaded (by Majavah; author: Majavah):

[cloud/toolforge/ingress-admission-controller@master] WIP: Admission review v1

https://gerrit.wikimedia.org/r/680650

gerritbot added a project: Patch-For-Review.Apr 17 2021, 8:57 AM

• Bstorm awarded a token.Apr 20 2021, 3:39 PM

taavi added a parent task: T264221: Upgrade the nginx ingress controller in Toolforge (and likely PAWS).Apr 20 2021, 5:59 PM

taavi mentioned this in T264221: Upgrade the nginx ingress controller in Toolforge (and likely PAWS).

taavi removed a parent task: T264221: Upgrade the nginx ingress controller in Toolforge (and likely PAWS).May 8 2021, 4:02 PM

taavi added a parent task: T286856: Upgrade Toolforge Kubernetes to latest 1.22.Jul 18 2021, 7:29 AM

Change 680650 merged by jenkins-bot:

[cloud/toolforge/ingress-admission-controller@master] Use Admission review v1 API

https://gerrit.wikimedia.org/r/680650

Mentioned in SAL (#wikimedia-cloud) [2021-08-12T15:02:29Z] <majavah> deploying ingress-admission-controller using v1 api T280436

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2021, 3:10 PM

Change 733669 had a related patch set uploaded (by Majavah; author: Majavah):

[labs/tools/registry-admission-webhook@master] Use Admission review v1 API

https://gerrit.wikimedia.org/r/733669

gerritbot added a project: Patch-For-Review.Oct 24 2021, 9:39 AM

Change 733669 merged by jenkins-bot:

[labs/tools/registry-admission-webhook@master] Use Admission review v1 API

https://gerrit.wikimedia.org/r/733669

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 7:10 PM

fully done!

taavi mentioned this in rLTRAbef40a01bf3f: Use Admission review v1 API.Nov 5 2021, 8:11 PM