Maniphest T281497

Hard deprecate Title::isWatchable()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	CCicalese_WMF
	Apr 29 2021, 4:00 PM

Tags

Referenced Files

None

Subscribers

Masumrezarock100

Description

Replace usages of Title::isWatchable() with WatchlistManager::isWatchable() and hard deprecate Title::isWatchable().

Wikimedia production extensions/skins:

Flow
MinervaNeue

Other extensions/skins:

BlueSpiceSocialWatch
~~WatchAnalytics~~ (filed an issue, but not a patch since the extension does not currently support MW 1.36+)

Core:

Remove usages in core
Hide deprecations in Title tests
Hard deprecate Title::isWatchable()

Details

	Subject	Repo	Branch	Lines +/-
	Hard deprecate Title::isWatchable()	mediawiki/core	master	+2 -0
	Replace Title::isWatchable() with WatchlistManager::isWatchable()	mediawiki/extensions/Flow	master	+4 -23
	Replace Title::isWatchable() with WatchlistManager::isWatchable()	mediawiki/core	master	+3 -3
	Replace Title::isWatchable() with WatchlistManager::isWatchable()	mediawiki/extensions/BlueSpiceSocialWatch	master	+1 -1
	Replace Title::isWatchable() with WatchlistManager::isWatchable()	mediawiki/skins/MinervaNeue	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned In: T292464: Remove hard deprecated Watchlist methods in User, Title, and WatchAction
rEBUYca379f88bdf7: Replace Title::isWatchable() with WatchlistManager::isWatchable()

Event Timeline

CCicalese_WMF created this task.Apr 29 2021, 4:00 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 29 2021, 4:00 PM

CCicalese_WMF moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.Apr 29 2021, 4:00 PM

CCicalese_WMF updated the task description. (Show Details)Apr 29 2021, 5:08 PM

Change 683688 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/Flow@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683688

gerritbot added a project: Patch-For-Review.Apr 29 2021, 5:16 PM

Change 683689 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683689

Change 683690 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/MinervaNeue@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683690

Change 683693 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/core@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683693

Change 683697 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/core@master] Hard deprecate Title::isWatchable()

https://gerrit.wikimedia.org/r/683697

Change 683690 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683690

CCicalese_WMF updated the task description. (Show Details)Apr 29 2021, 9:48 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 29 2021, 10:00 PM

Change 683689 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683689

CCicalese_WMF mentioned this in rEBUYca379f88bdf7: Replace Title::isWatchable() with WatchlistManager::isWatchable().Apr 30 2021, 8:11 AM

CCicalese_WMF updated the task description. (Show Details)Apr 30 2021, 12:20 PM

Change 683693 merged by jenkins-bot:

[mediawiki/core@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683693

Change 683688 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace Title::isWatchable() with WatchlistManager::isWatchable()

https://gerrit.wikimedia.org/r/683688

Change 683697 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate Title::isWatchable()

https://gerrit.wikimedia.org/r/683697

CCicalese_WMF closed this task as Resolved.Apr 30 2021, 6:51 PM

CCicalese_WMF updated the task description. (Show Details)

CCicalese_WMF moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 7:10 PM

CCicalese_WMF mentioned this in T292464: Remove hard deprecated Watchlist methods in User, Title, and WatchAction.Oct 4 2021, 5:22 PM