Maniphest T281556

Clean up WikibaseRepoTest
Closed, ResolvedPublic
Actions

Assigned To

Lucas_Werkmeister_WMDE

Authored By

	Lucas_Werkmeister_WMDE
	Apr 30 2021, 9:40 AM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

WikibaseClientTest was already removed, but there’s still some random stuff left in WikibaseRepoTest. We should check which parts we still want to keep, and remove the rest.

(If we want to keep anything, then maybe we should also resurrect some version of WikibaseClientTest?)

Details

	Subject	Repo	Branch	Lines +/-
	Replace WikibaseRepoTest with tests for service accessors	mediawiki/extensions/Wikibase	master	+100 -373
	Resurrect WikibaseClientTest	mediawiki/extensions/Wikibase	master	+123 -0

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 30 2021, 9:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2021, 9:40 AM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 30 2021, 9:40 AM

Lucas_Werkmeister_WMDE claimed this task.Apr 30 2021, 1:32 PM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 683903 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Replace WikibaseRepoTest with tests for service accessors

https://gerrit.wikimedia.org/r/683903

gerritbot added a project: Patch-For-Review.Apr 30 2021, 2:25 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 30 2021, 2:25 PM

Change 683923 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Resurrect WikibaseClientTest

https://gerrit.wikimedia.org/r/683923

Change 683903 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace WikibaseRepoTest with tests for service accessors

https://gerrit.wikimedia.org/r/683903

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 5:00 PM

Change 683923 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Resurrect WikibaseClientTest

https://gerrit.wikimedia.org/r/683923

Lucas_Werkmeister_WMDE closed this task as Resolved.May 3 2021, 8:12 AM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.