Page MenuHomePhabricator
Create Task
Maniphest T281598

Hard deprecate wfCanIPUseHTTPS
Closed, ResolvedPublic
Actions

Description

Soft deprecated in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/675293 and now always returns true. Extensions that require 1.37+ can just remove the call.

Per codesearch, all known uses are either in core, or CentralAuth which already requires 1.37

Details

SubjectRepoBranchLines +/-
Remove uses and hard deprecate wfCanIPUseHTTPSmediawiki/coremaster+5 -15
Remove calls to wfCanIPUseHTTPSmediawiki/extensions/CentralAuthmaster+4 -11
Customize query in gerrit

Event Timeline

DannyS712 created this task.Apr 30 2021, 6:57 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 30 2021, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Apr 30 2021, 6:57 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Apr 30 2021, 6:58 PM

Change 683951 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CentralAuth@master] Remove calls to wfCanIPUseHTTPS

https://gerrit.wikimedia.org/r/683951

gerritbot added a project: Patch-For-Review.Apr 30 2021, 6:58 PM
gerritbot added a comment.Apr 30 2021, 7:06 PM

Change 683952 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove uses and hard deprecate wfCanIPUseHTTPS

https://gerrit.wikimedia.org/r/683952

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 30 2021, 7:10 PM
gerritbot added a comment.May 3 2021, 2:29 AM

Change 683951 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove calls to wfCanIPUseHTTPS

https://gerrit.wikimedia.org/r/683951

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 3:00 AM
DannyS712 closed this task as Resolved.May 3 2021, 3:08 AM
gerritbot added a comment.May 3 2021, 3:18 AM

Change 683952 merged by jenkins-bot:

[mediawiki/core@master] Remove uses and hard deprecate wfCanIPUseHTTPS

https://gerrit.wikimedia.org/r/683952

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 4:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL