Maniphest T281635

CleanupAncientTables.php runs even without --force
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	RobinHood70
	May 2 2021, 6:06 AM

Tags

Referenced Files

None

Subscribers

Description

The CleanupAncientTables.php maintenance script always runs, regardless of the absence of the --force option.

It's unclear if the script was supposed to abort immediately after the error message (which it doesn't, since the die parameter isn't set) or if it was supposed to do a dry run and the code was never added for that.

Details

	Subject	Repo	Branch	Lines +/-
	Delete maintenance/cleanupAncientTables.php	mediawiki/core	REL1_35	+0 -115
	Delete maintenance/cleanupAncientTables.php	mediawiki/core	REL1_36	+0 -115
	Delete maintenance/cleanupAncientTables.php	mediawiki/core	master	+0 -115

Customize query in gerrit

Related Objects

Mentioned Here: rMW25017c83e13c: Work in progress (can kill another patch hanging around in my working copy)

Event Timeline

RobinHood70 created this task.May 2 2021, 6:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2021, 6:06 AM

Apparently I wrote this in 2012. Why, or for what exactly, I'm not sure. It was labelled as being WIP - rMW25017c83e13c: Work in progress (can kill another patch hanging around in my working copy)

It should probably just be dropped.

Change 684133 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684133

gerritbot added a project: Patch-For-Review.May 3 2021, 12:07 AM

Change 684133 merged by jenkins-bot:

[mediawiki/core@master] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684133

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 7:10 PM

Change 684456 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684456

Change 684457 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684457

https://www.mediawiki.org/wiki/Manual:CleanupAncientTables.php needs updating...

Change 684457 merged by jenkins-bot:

[mediawiki/core@REL1_36] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684457

Change 684456 merged by jenkins-bot:

[mediawiki/core@REL1_35] Delete maintenance/cleanupAncientTables.php

https://gerrit.wikimedia.org/r/684456

ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.35-notes.May 8 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 8 2021, 6:10 PM