Page MenuHomePhabricator

tweak AbuseFilter config on hiwiki (rm 1 line)
Closed, ResolvedPublic


Author: mayurdce

Hi i am a bureaucrat from hi wiki and Due to concern with privacy policy of wikimedia foundation please remove this array from abuse filter exetension as soon as possible
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:24 PM
bzimport set Reference to bz26364.
bzimport added a subscriber: Unknown Object (MLST).

The reason for this request is to block crats from viewing IPs in the abusefilter logs.

This looks right per (comment in the if block is "Private stuff, like IPs.")

Should be good now:

  • abusefilter.php (revision 1369)

+++ abusefilter.php (working copy)
@@ -72,7 +72,7 @@

	$wgGroupPermissions['abusefilter']['abusefilter-modify'] = true;
	$wgGroupPermissions['bureaucrat']['abusefilter-modify-restricted'] = true;
	$wgGroupPermissions['bureaucrat']['abusefilter-revert'] = true;
  • $wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;

+ $wgGroupPermissions['bureaucrat']['abusefilter-private'] = false;

	$wgGroupPermissions['sysop']['abusefilter-revert'] = true;
	$wgGroupPermissions['sysop']['abusefilter-modify'] = false;
	$wgGroupPermissions['*']['abusefilter-log-detail'] = true;

mayurdce wrote:

No this is not disabled so far, it is still showing that right in special:user group rights and abuse log we are able to see ips

mayurdce wrote:

it will better to remove this array-
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;

rather than setting it to false value

mayurdce wrote:

you have instered this array two times
see above-

$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = false;

one time for true and one time for false, that why it is not working, remove one array and set one to false, or remove both array

mayurdce wrote:

As this bug has been fixed, i am closing this bug.Thanking you very much for a quick respose to this emergency bug