Page MenuHomePhabricator

ChessBrowser fails to parse PGN where the result is 1/2-1/2
Closed, ResolvedPublicBUG REPORT

Description

here is chessbrowser beta, with one of the test games from the extension test pgns:
/includes/PgnParser/test/pgn/pgn-with-arrows.pgn

https://en.wikipedia.beta.wmflabs.org/wiki/User:%D7%A7%D7%99%D7%A4%D7%95%D7%93%D7%A0%D7%97%D7%A91/ChessBrowser_test_cases

it says "The PGN specified is invalid"
replacing the result from 1/2-1/2 to 1-0, or symply removing the result will display the game.

peace

Event Timeline

Wugapodes triaged this task as High priority.
Wugapodes moved this task from Needs triage to In Progress on the ChessBrowser board.
Wugapodes changed the subtype of this task from "Task" to "Bug Report".

Change 705193 had a related patch set uploaded (by Wugapodes; author: Wugapodes):

[mediawiki/extensions/ChessBrowser@master] ChessBrowser: Fix PGN validation regex

https://gerrit.wikimedia.org/r/705193

Change 705193 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] ChessBrowser: Fix PGN validation regex

https://gerrit.wikimedia.org/r/705193