Page MenuHomePhabricator
Create Task
Maniphest T284812

Move WikibaseClient EntityChangeLookup to service container
Closed, ResolvedPublic
Actions

Description

DirectSqlStore::getEntityChangeLookup() could be moved to the service container, in order to reduce the size of that class (listed as a desirable goal in T283334).

Details

SubjectRepoBranchLines +/-
client: move EntityChangeLookup to service containermediawiki/extensions/Wikibasemaster+71 -41
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 11 2021, 10:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2021, 10:48 AM
gerritbot added a comment.Jun 11 2021, 11:07 AM

Change 699400 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] client: move EntityChangeLookup to service container

https://gerrit.wikimedia.org/r/699400

gerritbot added a project: Patch-For-Review.Jun 11 2021, 11:07 AM
Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech (wdwb-tech (small tasks)).Jun 11 2021, 11:07 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot added a project: Wikidata.Jun 11 2021, 11:45 AM
gerritbot added a comment.Jun 11 2021, 5:39 PM

Change 699400 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: move EntityChangeLookup to service container

https://gerrit.wikimedia.org/r/699400

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 11 2021, 5:42 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 11 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL