Maniphest T285261

Technical debt: Remove year old FIXMEs in the Minerva code
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 21 2021, 5:55 PM

Tags

Referenced Files

None

Subscribers

Masumrezarock100

polishdeveloper

Description

While looking at Minerva several FIXMes were noticed relating to changes for cached HTML T259628, T198947 and a 2020 change (https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/592741), all of which were done long

They serve no purpose, and should have been removed a long time ago. Let's do that now.
The FIXMES are in code relating to the header and footer including last modified bar. This ticket acts as a placeholder so the team is aware this change has occurred.

Details

	Subject	Repo	Branch	Lines +/-
	Address some FIXMEs in styles	mediawiki/skins/MinervaNeue	master	+1 -16

Customize query in gerrit

Related Objects

Mentioned Here: T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility
T259628: Last modified bar in Minerva is parsing invalid wikitext - could break in future

Event Timeline

Jdlrobson created this task.Jun 21 2021, 5:55 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 21 2021, 5:55 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 21 2021, 5:55 PM

Change 700256 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Address some FIXMEs in styles

https://gerrit.wikimedia.org/r/700256

gerritbot added a project: Patch-For-Review.Jun 21 2021, 5:56 PM

Jdlrobson triaged this task as Medium priority.Jun 21 2021, 5:56 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 0.5.

Jdlrobson assigned this task to polishdeveloper.Jun 21 2021, 6:03 PM

Change 700256 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Address some FIXMEs in styles

https://gerrit.wikimedia.org/r/700256

Jdlrobson removed polishdeveloper as the assignee of this task.Jun 21 2021, 8:18 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson added a subscriber: polishdeveloper.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2021, 9:10 PM

Jdlrobson closed this task as Resolved.Jun 21 2021, 11:11 PM

Jdlrobson claimed this task.