Page MenuHomePhabricator
Create Task
Maniphest T285863

Link to actual types for parameters/return in jsdoc
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Instead of generic {Object} with text explaining what it is, we should link to the actual type directly
Also, realized that all of the places that say "jQuery.Promise" should really just be "Promise"

Details

SubjectRepoBranchLines +/-
Document SiteDisplay.actuallyRenderWatchlist parameter as jQuerymediawiki/extensions/GlobalWatchlistmaster+1 -1
JSDoc updates to link typesmediawiki/extensions/GlobalWatchlistmaster+26 -18
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jun 30 2021, 2:29 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 30 2021, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 30 2021, 2:30 PM

Change 702387 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] JSDoc updates to link types

https://gerrit.wikimedia.org/r/702387

gerritbot added a project: Patch-For-Review.Jun 30 2021, 2:30 PM
DannyS712 triaged this task as Low priority.Jun 30 2021, 2:34 PM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 2.
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jul 2 2021, 1:12 PM

Change 702387 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] JSDoc updates to link types

https://gerrit.wikimedia.org/r/702387

jenkins-bot mentioned this in rEGLW8f2ff7c43ac7: JSDoc updates to link types.Jul 2 2021, 1:12 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 2:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 2:11 PM
gerritbot added a comment.Jul 2 2021, 3:11 PM

Change 702948 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Document SiteDisplay.actuallyRenderWatchlist parameter as jQuery

https://gerrit.wikimedia.org/r/702948

gerritbot added a project: Patch-For-Review.Jul 2 2021, 3:11 PM
gerritbot added a comment.Jul 2 2021, 5:47 PM

Change 702948 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Document SiteDisplay.actuallyRenderWatchlist parameter as jQuery

https://gerrit.wikimedia.org/r/702948

jenkins-bot mentioned this in rEGLWdf2516248b35: Document SiteDisplay.actuallyRenderWatchlist parameter as jQuery.Jul 2 2021, 5:47 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 6:10 PM
DannyS712 closed this task as Resolved.Jul 4 2021, 2:57 AM
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 2.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits