Page MenuHomePhabricator
Create Task
Maniphest T28724

TalkHere throws a fatal error when $wgMaxCredits in not 0
Closed, ResolvedPublic
Actions

Description

When using TalkHere extension with $wgMaxCredits different than 0, the following error happens:

Catchable fatal error: Argument 1 passed to Credits::getCredits() must be an instance of Article, instance of TalkHereArticle given, called in includes/SkinTemplate.php on line 386 and defined in includes/Credits.php on line 59

Version: unspecified
Severity: enhancement

Details

Reference
bz26724

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
• bzimport added a project: MediaWiki-extensions-Other.
• bzimport set Reference to bz26724.
• bzimport added a subscriber: Unknown Object (MLST).
IAlex created this task.Jan 14 2011, 10:36 AM
daniel added a comment.Jan 14 2011, 10:55 AM

What the hell is Credits?

Anyway, I suppose it'S a bug in Credits, not TalkHere: From what I gether, Credits::getCredits() checks that the argument is an instance of Article, instead of checking if it's an *compatible* with the Article class. It should use instanceof instead getclass.

I can't do much about it from my side, so i'm assigning it back to the ML.

IAlex added a comment.Jan 15 2011, 3:51 PM

Fixed in r80403 and r80404.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL