Page MenuHomePhabricator
Create Task
Maniphest T287699

Cannot create repository from toolforge interface if no Phabricator accounts can be found for the tool's maintainer list
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
TheresNoTime
Authored By
TheresNoTime
Jul 29 2021, 5:59 PM
Tags
Referenced Files
F34569661: image.png
Jul 29 2021, 5:59 PM
F34569660: image.png
Jul 29 2021, 5:59 PM
Subscribers
Aklapper
bd808
taavi
TheresNoTime
Tokens
"The World Burns" token, awarded by TheresNoTime.

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The error "No Phabricator accounts found for tool maintainers." is shown, and the repository is not created

What should have happened instead?:
A repository was created

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

image.png (386×809 px, 23 KB)

On some further diagnosis, it appears the issue could have something to do with my account links.

image.png (664×675 px, 39 KB)

  • Clicking "Refresh phabricator data" gives the error No related Phabricator accounts found.
  • Clicking "Refresh OAuth credentials" gives the error Wikimedia account "TheresNoTime" is already attached to another LDAP account.

I'm not aware of it being attached to any other accounts.

Related Objects

Event Timeline

TheresNoTime created this task.Jul 29 2021, 5:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2021, 5:59 PM
taavi edited projects, added Striker; removed Toolforge.Jul 29 2021, 6:23 PM
taavi subscribed.

Poking at Striker's admin console reveals that it thinks you have two different developer accounts, Samtar and TheresNoTime. Samtar is linked to SUL account named "There'sNoTime" and this Phabricator account, and TheresNoTime is linked to SUL account "TheresNoTime" but not linked to any phabricator accounts. Both developer accounts have the same email (which is bound to cause trouble with some services, even if only one is used). Not exactly sure why it doesn't let you update the Phabricator account details on Samtar, as the Phabricator account you used to create this task seems to be linked correctly to that developer account.

TheresNoTime awarded a token.Jul 29 2021, 6:53 PM
taavi added a comment.Jul 30 2021, 9:03 AM

Ah, I think I found why this is happening! Your Phabricator account isn't linked to any of the accounts the "Samtar" developer account is linked to on Striker, instead it's linked to the "TheresNoTime" SUL account (which is turn linked to the TheresNoTime developer account on toolsadmin) and not linked to any developer accounts. For some reason Striker/toolsadmin wants at least one of those links to match.

TheresNoTime closed this task as Resolved.Jul 30 2021, 9:06 AM
TheresNoTime claimed this task.
In T287699#7248148, @Majavah wrote:

Ah, I think I found why this is happening! Your Phabricator account isn't linked to any of the accounts the "Samtar" developer account is linked to on Striker, instead it's linked to the "TheresNoTime" SUL account (which is turn linked to the TheresNoTime developer account on toolsadmin) and not linked to any developer accounts. For some reason Striker/toolsadmin wants at least one of those links to match.

Issue resolved - I added my LDAP account (Samtar) to phab, and retried creating the repository. This worked. Nice work, and thank you for the help!

bd808 subscribed.Jul 30 2021, 4:07 PM
In T287699#7248148, @Majavah wrote:

Ah, I think I found why this is happening! Your Phabricator account isn't linked to any of the accounts the "Samtar" developer account is linked to on Striker, instead it's linked to the "TheresNoTime" SUL account (which is turn linked to the TheresNoTime developer account on toolsadmin) and not linked to any developer accounts. For some reason Striker/toolsadmin wants at least one of those links to match.

Striker needs to find one or more Phabricator users to grant control of the Diffusion repository to. The lookup of Phabricator accounts is done using two conduit api calls. The first call is to https://phabricator.wikimedia.org/conduit/method/user.ldapquery/ to look for Phabricator accounts connected to Developer accounts that are also maintainers of the tool that the repo will belong to. The second call is to https://phabricator.wikimedia.org/conduit/method/user.mediawikiquery/ to look for Phabricator accounts connected to SUL accounts that are connected to Developer accounts that are also maintainers of the tool that the repo will belong to. The union of all Phabricator accounts found via these two lookups are granted "owner" level rights on the newly created Diffusion repository. When no accounts are found, then the whole process aborts so that we don't create orphan repos.

bd808 renamed this task from Cannot create repository from toolforge interface to Cannot create repository from toolforge interface if no Phabricator accounts can be found for the tool's maintainer list.Jul 30 2021, 4:07 PM
TheresNoTime mentioned this in T302109: Delete "theresnotime" LDAP account.Feb 18 2022, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits