Page MenuHomePhabricator

GUC: Link in edit summary with fragment containing apostrophe doesn't work
Open, MediumPublicBUG REPORT

Description

I've copied one line of my global contributions at https://en.wikipedia.org/wiki/User:Jonteemil/sandbox5. The link to the section which is represented by →‎ should direct you to https://fr.wikipedia.org/wiki/Wikipédia:Demande_de_renommage#Correcting_file_extensions_that_currently_doesn't_match_MIME but currently directs you to https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Demande_de_renommage#Correcting_file_extensions_that_currently_doesn.26.23039.3Bt_match_MIME.

The apostrophy is replaced by .26.23039.3B for some reason. I would assume it is the same with other types of non-letter symbols. Anyway, you don't get sent to the section, which is a problem.

Event Timeline

ahmedsajib set Due Date to Aug 24 2021, 12:00 AM.Aug 24 2021, 11:37 PM
Jonteemil changed the subtype of this task from "Task" to "Bug Report".Sep 8 2021, 12:24 PM
Krinkle triaged this task as Medium priority.Oct 29 2022, 2:12 AM
Krinkle moved this task from Inbox to Confirmed Problem on the Tool-Global-user-contributions board.
Krinkle added a project: patch-welcome.
Krinkle subscribed.

This is due to a change from a few years ago where MediaWiki gradually migrated from legacy to HTML5 URL fragment encoding for its headings. GUC still has the old encoding logic.

The code resides in guc.git:/src/App.php#wikiparser and contains comments pointing to the MediaWiki core codebase equivalent.

Krinkle renamed this task from Apostrophy doesn't work in link to GUC: Link in edit summary with fragment containing apostrophe doesn't work.Oct 29 2022, 2:13 AM