Page MenuHomePhabricator
Create Task
Maniphest T288311

UserDef parameter should return UserIdentityValue instead of User
Closed, ResolvedPublic
Actions

Description

Documented to only be a UserIdentity object, currently its a full User though (when PARAM_RETURN_OBJECT is enabled)

Details

SubjectRepoBranchLines +/-
UserDef: creating from id 0 should be unknown user, not context ipmediawiki/coremaster+21 -49
UserDef: no need to return full User objectsmediawiki/coremaster+114 -59
ApiUserrights: remove use of UserDef::PARAM_RETURN_OBJECTmediawiki/coremaster+0 -1
UserDef only returns UserIdentitymediawiki/extensions/GrowthExperimentsmaster+3 -3
Customize query in gerrit

Event Timeline

DannyS712 created this task.Aug 5 2021, 11:09 PM
Restricted Application edited projects, added User-DannyS712; removed Patch-For-Review. · View Herald TranscriptAug 5 2021, 11:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added a project: Patch-For-Review.Aug 5 2021, 11:10 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Aug 5 2021, 11:10 PM

Change 703416 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] UserDef: no need to return full User objects

https://gerrit.wikimedia.org/r/703416

gerritbot added a comment.Aug 5 2021, 11:10 PM

Change 708223 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] UserDef: creating from id 0 should be unknown user, not context ip

https://gerrit.wikimedia.org/r/708223

gerritbot added a comment.Aug 5 2021, 11:11 PM

Change 710386 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GrowthExperiments@master] UserDef only returns UserIdentity

https://gerrit.wikimedia.org/r/710386

DannyS712 updated the task description. (Show Details)Aug 5 2021, 11:13 PM
gerritbot added a comment.Aug 5 2021, 11:21 PM

Change 710388 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] ApiUserrights: remove use of UserDef::PARAM_RETURN_OBJECT

https://gerrit.wikimedia.org/r/710388

gerritbot added a comment.Aug 5 2021, 11:52 PM

Change 710386 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] UserDef only returns UserIdentity

https://gerrit.wikimedia.org/r/710386

gerritbot added a comment.Aug 5 2021, 11:57 PM

Change 710388 merged by jenkins-bot:

[mediawiki/core@master] ApiUserrights: remove use of UserDef::PARAM_RETURN_OBJECT

https://gerrit.wikimedia.org/r/710388

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 6 2021, 12:00 AM
gerritbot added a comment.Sep 14 2021, 3:46 AM

Change 703416 merged by jenkins-bot:

[mediawiki/core@master] UserDef: no need to return full User objects

https://gerrit.wikimedia.org/r/703416

gerritbot added a comment.Sep 14 2021, 3:46 AM

Change 708223 merged by jenkins-bot:

[mediawiki/core@master] UserDef: creating from id 0 should be unknown user, not context ip

https://gerrit.wikimedia.org/r/708223

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 4:00 AM
DannyS712 closed this task as Resolved.Sep 28 2021, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits