Page MenuHomePhabricator

First paragraph should not have text-indent:0 in Page: namespace if inside a parent container has already set this to something else.
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The first paragraph on the page (below the header) has an indent on the first line in the scan, but not in the rendered/produced output.

What should have happened instead?:
The first paragraph (below the header) in the rendered output on the page should have its first line indented, per the styles set by the wrapping container ( in this instance a DIV)

Other information, etc:

Further investigation, showed that although the wrapper DIV (in this case the template: {{dent/s}} is correctly applying the margins and text-indent set in the template (as inline CSS), this is being overridden by a CSS rule set for the first paragraph, by the Proofread Page extension itself.

The CSS rule responsible was added 3 weeks ago in "ext.proofreadpage.page.css" see:-
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/700442/4/modules/page/ext.proofreadpage.page.css

Where the parent container is already setting the text-indent, this should not be overridden.

Event Timeline

Change 710511 had a related patch set uploaded (by Aklapper; author: Tpt):

[mediawiki/extensions/ProofreadPage@master] Page: pages: only remove intend of the first not nested paragraph

https://gerrit.wikimedia.org/r/710511

Change 710511 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Page pages: do not remove the identation the first paragraph

https://gerrit.wikimedia.org/r/710511

Tpt claimed this task.
Tpt subscribed.

Fixed and deployed.