I believe everything has been converted. We still have T146160 opened, but it's not related to HTML input elements.

@bd808 Thank you very much for having had a look at it! I believe that waiting for Stretch deployment is indeed the easiest way to go.

For this task to be done, the extension should be deployed on Wikisource: T210174

Great idea! I'll be very happy to +2 a change.

@TheDJ getSelection is overrided to support Wikitext to VE switch. We should definitely make header/footer compatible with textSelection. I have not taken time to implement this change yet. But if someone could write it, it would be much appreciated.

I just had a quick review of the current GraphQL structure for Wikibase entities. It looks great! Thank you!

Thanks! The current task seems to duplicate that one indeed.

So you're not really asking for a change in the JSON-LD, you're asking for wikidata to only emit a single entity on the /entity/* endpoint -- and that would/could apply to all the different representations using the purtle backend. That's not a JSON-LD specific request.

@daniel We could do something similar for stubs. with structures like:

Not a problem but a cosmetic proposal: Instead of having the structure:

@Reedy Should we close this task? The related change have been merged

For example if the call to mapframe is:

It seems to me that the only thing missing in the implementation compared to https://www.mediawiki.org/wiki/Extension:WikibaseLexeme/RDF_mapping is the addition of schema:inLanguage for Lexemes. But it is derived data so it should not block the deployment to query.wikidata.org.

Yes

Thank you @Pintoch for raising this idea. For my fixing constraints violations project, I can mine violations from history offline so I do not really need this feature.

@Jonas Thank you for your feedback.

Sorry everyone for the troubles. I was experimenting with a tool that tries to find corrections for constraint violations.
I have modified it to send a proper User-Agent for all its requests to the Wikidata API but not restarted it.

I would wait for addition of proper statement serialization that is tracked by T195043.

With that.. I think it would be best if we moved your code to a new "graphql" repo, host the GraphQL server on a Cloud VPS, and then rewrite it in JavaScript (node.js) so it's as fast as it can be. If it gets enough usage we can talk about moving it onto production. :) What do you think? does that sound like a plan?

In T173214#4511651, @dbarratt wrote:

In T173214#4457079, @Tpt wrote:

For statement filtering by qualifier a good solution is maybe to add an extra parameter "hasStatement" to the statements field and give to it a value of type SnakInput (a GraphQL input type that would be used to encode a snak provided by the GraphQL client). What do you think about it?

So it looks like the proper way to do this is with a Directive. Then again, I'm not really sure I understand the difference between Directives and Arguments. Perhaps arguments can only be used on objects and Directives can be used on any type?

@dbarratt Thank you for planning to work on Wikibase+GraphQL.

@Ankry the fix is planned to be deployed soon. Have some real pages still affected is a good way to check that the problem is indeed solved.

@Tpt any idea how can we create propoer header/footer here (if this is the source of the problem)?

It seems that the two pages could be parsed as JSON by PHP and so, ProofreadPage assumes that they are using the JSON serialization for Page: pages. But, because they are not using the good JSON serialization format, an exception is thrown.

I have just made a change that uses LinkRender instead of Linker and, so, should fix the possible XSS injection https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ProofreadPage/+/450398/

I also checked about the potential SQLi and I don't see how it could happen. All "conds" arguments are key-values where the key is a string so should be properly escaped. More values seems to always be an integer or an array of DBKey obtained by using the Title::getDBKey method. The error are maybe raised because the query is constructed in a different class than the one where the execution is called.

Also, I understand it's still disabled on both wikidata and test.wikidata.

There is still one feature missing: outputting statements on form and senses when the RDF representation of a lexeme is required (e.g. on Special:EntityData/L12.nt).

Is https://gerrit.wikimedia.org/r/449718 covering this?

Indeed the set of property and their datatypes is very static and cachable so we could use them as keys of a StatementByProperty object and then have StringStatement, StringSnak... types. The object would just be huge and maybe raise some performance problems of the various GraphQL tools (we would have 4K+ keys).

Thanks!

Deployed

Thank you!

Thank you!

@Tpt so it looks like right now you can't get a datavalue or recursively call item from a statement. I added a sample query to the task description.

Done as part of T153120

@Billinghurst Is the problem still happening now that the quality color bug is solved?

The fallback to the categories seems to work. I plan to keep it as long as their exists Page: pages that do not contain the pageproperty

Sorry, I was wrong, the fix is not deployed yet. It should be deployed this evening UTC.

As a logged-in user, it will also show normally/as expected.

@Tpt it does not seem to work: https://fr.wikisource.org/wiki/Livre:Revue_du_monde_nouveau,_vol._I,_1874.djvu

The change that should fix this problem have been deployed yesterday. A purge of the pages where blank ids are displayed should fix the problem (for Index: pages it could be done with a not null edit on MediaWiki:Proofreadpage_index_template)

This is a side effect of T198470. A fix for it should be deployed next week.

Fallback have been implemented and merged into ProofreadPage. It is live now on https://en.wikisource.beta.wmflabs.org and will be deployed on Wikisources next Tuesday.

@Ankry here is the query you are looking for: https://quarry.wmflabs.org/query/27922