Page MenuHomePhabricator

Tpt (Tpt)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:56 AM (403 w, 3 d)
Availability
Available
IRC Nick
Tpt
LDAP User
Tpt
MediaWiki User
Tpt [ Global Accounts ]

Recent Activity

May 29 2022

Tpt added a comment to T309451: Live preview shows incorrect proofread status.

Indeed, this bug is related to c1f80efe05349cc39cb82dc9347b0a7699b11dfd (T304303): the live preview feature relies on the JS API allowing to fetch the current content of the editing area. To fix T183950 we dropped the hack inside of ProofreadPage that provides not only the page body but also the proofreading level and the page header/footer as page content. So, after this change, only the page body is fed to the live preview feature, hence the bug. A possible solution might be to add back the "complete page content" hack inside of ProofreadPage but some signficant work would be required to make features like find/replace work with this hack.

May 29 2022, 10:26 AM · MediaWiki-Page-editing, ProofreadPage

May 26 2022

Tpt added a comment to T128173: Represent editions as interwiki links on Wikisource.

I have written an implementation draft: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/793867

May 26 2022, 2:43 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), All-and-every-Wikisource, Wikidata

May 9 2022

Samwilson awarded T307956: IA-upload: Drop phetools dependency a Like token.
May 9 2022, 11:22 PM · IA Upload
Tpt created T307956: IA-upload: Drop phetools dependency.
May 9 2022, 7:16 PM · IA Upload

Mar 27 2022

Tpt created T304795: Drop the ProofreadPageUseStatusChangeTags option.
Mar 27 2022, 1:59 PM · Patch-For-Review, Wikimedia-Site-requests, ProofreadPage

Feb 14 2022

Tpt added a comment to T301655: HTML entity error (unencoded ampersand) in OPDS export for Wikisource.

A fix has just been merged https://github.com/wikimedia/ws-export/pull/397 with a nicer follow up https://github.com/wikimedia/ws-export/pull/398

Feb 14 2022, 8:44 AM · Community-Tech, WS Export

Jan 31 2022

Tpt updated the task description for T289760: Evaluate Oxigraph as alternative to Blazegraph.
Jan 31 2022, 7:28 AM · Wikidata, Wikidata-Query-Service

Jan 13 2022

Tpt added a comment to T299124: ProofreadPage frontend makes a request to the page before and after in every page view.

rel=prefetch has been added targetting the previous and next pages to speed up bulk proofreading according to T230689

Jan 13 2022, 10:49 AM · ProofreadPage

Jan 7 2022

Tpt added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

@Xover Sadly there is not hope for it to be pushed today except if someone is managing to follow the emergency deployment process: https://wikitech.wikimedia.org/wiki/Deployments/Emergencies

Jan 7 2022, 11:18 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Tpt triaged T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode as High priority.

High priority: breaks a part of the basic Wikisource proofreading workflow.

Jan 7 2022, 8:20 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 6 2022

Tpt added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

@Inductiveload Thank you!

Jan 6 2022, 5:41 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Tpt added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

I wrote a change that should fix the bug https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/751946/

Jan 6 2022, 4:11 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 4 2022

Tpt added a comment to T292365: IA-Upload does not take care of disk space when accepting jobs.

The bug happend again on the new disk with the "exhibitorsherald2*" files. I removed them to put the tool back on. We should maybe prevent files >1GB to be downloaded and processed.

Jan 4 2022, 8:04 PM · IA Upload

Dec 8 2021

Soda awarded T291082: Grant Inductiveload +2 right on ProofreadPage a Like token.
Dec 8 2021, 4:28 PM · ProofreadPage, Gerrit-Privilege-Requests

Dec 1 2021

Tpt added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

@Xover Thank you so much for having found this issue. It was under my nose all this time.

Dec 1 2021, 3:51 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 24 2021

Tpt closed T217488: Move ProofreadPage class into ProofreadPage namespace as Resolved.
Nov 24 2021, 4:28 PM · ProofreadPage
Tpt added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

@Mahir256 The change I wrote is in fact buggy. It's looking for a field named "toc" and not a field which data field is "toc". I'm writing a fix right now. Sorry for that.

Nov 24 2021, 2:05 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 23 2021

Tpt added a comment to T296325: Investigate Page namespace 1.5x/2x image without zooming in .

@Soda do you have a HiDPI screen? If it's the case, I believe modern browsers will download and use the bigger image that is provided by the srcset attribute before the initialization of Openseadragon. Then Openseadragon is initialized and use the regular size image. It's what happens with my 4K screen configured with 2x scaling.

Nov 23 2021, 7:39 PM · ProofreadPage

Nov 21 2021

Tpt added a comment to T268932: Add Bengali currency/hexadecimal numerals to pagelist.

Sorry, I made a confusion between two different numerical systems: the ICU "beng" numerals are defined as the 10 digits "০১২৩৪৫৬৭৮৯" and, so, are not using base 16 as the currency numerals requested by this task. The base 10 numerical system is properly implemented and available now, the base 16 numerals are not yet availlable and not provided by ICU.

Nov 21 2021, 7:51 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Bengali-Sites, I18n, ProofreadPage
Tpt added a comment to T268932: Add Bengali currency/hexadecimal numerals to pagelist.

@Inductiveload I believe @Bodhisattwa says that the "beng" option is not visible in the pagelist editing widget.

Nov 21 2021, 7:36 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Bengali-Sites, I18n, ProofreadPage

Nov 19 2021

Tpt added a comment to T289760: Evaluate Oxigraph as alternative to Blazegraph.

@Thadguidry @BenAtOlive It's a great idea to move the conversation somewhere else. Oxigraph has a discussion space and a Gitter channel.

Nov 19 2021, 8:05 PM · Wikidata, Wikidata-Query-Service
Tpt added a comment to T289760: Evaluate Oxigraph as alternative to Blazegraph.

@BenAtOlive If I understand correctly, you are asking if Oxigraph can be used to build a distributed SPARQL database with reader nodes and writer nodes? Its definitely possible to reuse Oxigraph components for that. For example I am currently moving the SPARQL parser out of Oxigraph and I plan to add general SPARQL query optimizations to it. However, building a query evaluator against a distributed storage where data are not in the same machine as the one executing (or at least scheduling) the query is a quite different task as building a query executor against a single node database. Access latencies are easily an order of magnitude higher with a remote store and it changes quite a lot of tradeoffs. So, yes for making the part of Oxigraph that are easy to reuse reusable but sadly I am not sure that naively spliting the query evaluator out of Oxigraph would provide a good query evaluator on top of a distributed storage.

Nov 19 2021, 7:44 PM · Wikidata, Wikidata-Query-Service

Nov 18 2021

Tpt closed T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages> as Resolved.

The change fixing this issue is now merged.

Nov 18 2021, 1:54 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 16 2021

Tpt added projects to T295771: Increase $wgMaximumMovedPages for eo.wikisource: Wikimedia-Site-requests, All-and-every-Wikisource.
Nov 16 2021, 1:55 PM · Community-Relations, Performance-Team, Wikimedia-Site-requests

Nov 15 2021

Tpt added a comment to T295275: Dedicated section on Wikidata Item and Property pages for classifying Properties.

It's a great idea! I just believe P2860 (cites work) should be removed from the list. It's definitely not a classifying property.

Nov 15 2021, 12:34 PM · Wikidata, Wikidata-Campsite

Oct 3 2021

Tpt triaged T292365: IA-Upload does not take care of disk space when accepting jobs as High priority.
Oct 3 2021, 12:40 PM · IA Upload
Tpt closed T292361: ia-upload server needs a prod as Resolved.

It is now fixed. There was some broken job data in the file system because of the full disk problem. I have opened T292365 to prevent it to happen again.

Oct 3 2021, 12:40 PM · IA Upload
Tpt created T292365: IA-Upload does not take care of disk space when accepting jobs.
Oct 3 2021, 12:40 PM · IA Upload
Tpt added a comment to T292361: ia-upload server needs a prod.

It's because the disk is currently full. I have removed a few huge books from the job queue and rebooted the server. However it does not seems to be enough to bring the website back.

Oct 3 2021, 12:25 PM · IA Upload

Oct 2 2021

Tpt committed R2221:88e916108c6c: Upgrades dependencies (authored by Tpt).
Upgrades dependencies
Oct 2 2021, 2:35 PM

Sep 17 2021

Tpt added a comment to T114318: Sometimes the anchor links generated by an Index: page's <pagelist /> do not have the expected class attribute and value set.

@Mpaa @Dvorapa @Dalba Sorry for distrubing you. Is this problem fixed now?

Sep 17 2021, 7:54 PM · TestMe, Pywikibot-tests, ProofreadPage, Pywikibot
Tpt added a comment to T290578: Use the change_tag table to store the proofreading quality level.

@Ladsgroup Thank you! So what would you think about MCR for storing the "main" data and some change tags as "secondary" data for queryability and recent changes filtering? This way we would get the best of both worlds.

Sep 17 2021, 2:18 PM · ProofreadPage

Sep 15 2021

Tpt added a comment to T290578: Use the change_tag table to store the proofreading quality level.

Thank you @Tgr and @Ladsgroup for your feedbacks!

Sep 15 2021, 9:02 PM · ProofreadPage
Tpt created T291082: Grant Inductiveload +2 right on ProofreadPage.
Sep 15 2021, 1:11 PM · ProofreadPage, Gerrit-Privilege-Requests

Sep 14 2021

Tpt updated subscribers of T290578: Use the change_tag table to store the proofreading quality level.

@Tgr @Legoktm Sorry for bothering you. I believe you where at some point involved in with change tags system. Do you think our plan seems sensible?

Sep 14 2021, 3:02 PM · ProofreadPage

Sep 13 2021

Tpt added a comment to T289140: ProofreadPage: Enable change-tag status system on Wikisources.

@Inductiveload Great question! We might start now. Maybe with oldwikisource?

Sep 13 2021, 6:14 PM · Patch-For-Review, ProofreadPage

Sep 8 2021

Tpt created T290578: Use the change_tag table to store the proofreading quality level.
Sep 8 2021, 3:05 PM · ProofreadPage

Sep 2 2021

Tpt added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

This still doesn't explain how the fields were there earlier, as the current text shows (which cannot be edited).

Sep 2 2021, 1:19 PM · ProofreadPage
Tpt added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

@Aklapper Thank you! Most of Wikisource now use that is an improved version of Mediawiki:Proofreadpage_index_attributes. MediaWiki:Proofreadpage_index_data_config is defined in the Hebrew Wikisource.

Sep 2 2021, 1:14 PM · ProofreadPage

Aug 31 2021

Tpt added a comment to T289760: Evaluate Oxigraph as alternative to Blazegraph.

@Thadguidry Great! Thank you!

Aug 31 2021, 2:47 PM · Wikidata, Wikidata-Query-Service
Tpt added a comment to T289760: Evaluate Oxigraph as alternative to Blazegraph.

@Thadguidry Hi! It's a great idea to improve the roadmap. Thank you for pushing me to do that! I have updated the GitHub issues and milestones and added a link to them in the README:
Each milestone should now have a short description and a set of linked issues. Most of the issues have been connected to a milestones.
I am a bit afraid of adding a ROADMAP file to the repository because it is yet another source of truth to maintain.
To also keep a single source of truth I made the choice to not expand the milestone description too much and keep the detailed discussions inside of issues. Here is [one about the storage backend and Sled]( https://github.com/oxigraph/oxigraph
/milestones?direction=desc&sort=completeness&state=open). However, the milestone+connected issues descriptions should allow to make sense of the roadmap. Feel free to ping me if you believe it's not clear enough.

Aug 31 2021, 6:57 AM · Wikidata, Wikidata-Query-Service

Aug 26 2021

Tpt added a comment to T289760: Evaluate Oxigraph as alternative to Blazegraph.

Thank you @So9q for opening this task!

Aug 26 2021, 3:57 PM · Wikidata, Wikidata-Query-Service

Aug 25 2021

Tpt added a comment to T289728: ProofreadPage\PageNumberNotFoundException: Page:[page] provides invalid page number .

I'm working on a fix. Should be ready soon. Sorry for the troubles.

Aug 25 2021, 8:18 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Vector (Vector (Tracking)), Platform Engineering, ProofreadPage, User-brennen, Wikimedia-production-error

Aug 12 2021

Tpt closed T288408: First paragraph should not have text-indent:0 in Page: namespace if inside a parent container has already set this to something else. as Resolved.

Fixed and deployed.

Aug 12 2021, 8:43 AM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), ProofreadPage

Aug 7 2021

Tpt added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

Sorry, I should not have closed this issue. The change that should fix this problem is not merged yet: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/704564
So, it makes sense that the problem does not seem solved on Wikisource.

Aug 7 2021, 7:43 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Aug 5 2021

Tpt added a comment to T288191: substituting {{#tag:ref}} tags and templates; and pipe tricks fail in Page namespace.

How widespread is the impact of this bug remaining unfixed? If it's a nitch use and we can fix it with a backport in the short term then I wouldn't roll back. On the other hand, if this is causing some fallout elsewhere or triggering major production breakage then definitely roll back.

Aug 5 2021, 8:11 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), MediaWiki-ContentHandler, Platform Team Workboards (MW Expedition), Regression, ProofreadPage

Aug 4 2021

Tpt closed T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages> as Resolved.

Yes. To make it work properly "data": "toc" should be added to the relevant field in Mediawiki:Proofreadpage_index_data_config.

Aug 4 2021, 4:43 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jul 31 2021

Tpt renamed T287809: phpcs should validate @return phpdoc annotations of abstract methods from phpcs should warn against common type variants like "boolean" or "integer" in PHPdoc comments to phpcs should validate @return phpdoc annotations of abstract methods.
Jul 31 2021, 7:38 AM · MediaWiki-Codesniffer
Tpt added a comment to T287809: phpcs should validate @return phpdoc annotations of abstract methods.

@DannyS712 Thank you! I have understood why e.g. https://phabricator.wikimedia.org/diffusion/EPRP/browse/master/includes/Pagination/Pagination.php$25 is not flagged by these sniffs. It's because abstract methods are not covered by the lint: https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/5f813f727ee47d5c90981b44e82f0c5a0263e933/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php#L198

Jul 31 2021, 7:33 AM · MediaWiki-Codesniffer
Tpt created T287809: phpcs should validate @return phpdoc annotations of abstract methods.
Jul 31 2021, 7:18 AM · MediaWiki-Codesniffer

Jul 19 2021

Tpt added a comment to T230689: Preload the next page's image on proofreading view.

Thank you @Ankry, @Xover @Inductiveload! So I guess rel="preload" seems the way to go for the next page image. What about using rel="prefetch" for the previous one? This way, it gets a good chance to be loaded too but with less priority. What do you think about it?

Jul 19 2021, 5:18 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage

Jul 17 2021

Tpt added a comment to T230689: Preload the next page's image on proofreading view.

@Ankry Thank you! So, I guess that the main goal is to make sure that the image thumbnail is already generated when a Page: page is displayed.

Jul 17 2021, 4:28 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage
Tpt added a comment to T230689: Preload the next page's image on proofreading view.

If I remind correctly preload is to ask the browser to aggressively fetch a content for the current page rendering and prefetch is to ask the browser to load the content for future use in the navigation.

Jul 17 2021, 7:41 AM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage

Jul 13 2021

Tpt created T286582: Duplicated links to Page: pages should be allowed in Index: pages relying on a PDF/DjVu file.
Jul 13 2021, 6:01 PM · Patch-For-Review, All-and-every-Wikisource, ProofreadPage

Jun 30 2021

Tpt added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

But aiui the granularity would be per-project and not per-index. How would a project start experimenting with this or avoid the need for a big bang migration? Use two toc fields in the index, one for the traditional way and one for a "Wikidata-based toc"? That would necessitate PRP differentiate between "present" and "non-empty" for the index data field tagged with "data": "toc", I think. That sounds a little more complicated, but is perhaps not too much so?

Jun 30 2021, 8:04 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jun 29 2021

Tpt added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

Thank you @Mahir256 and @Xover for this discussion.

Jun 29 2021, 8:08 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jun 8 2021

Tpt added a comment to T274350: ProofreadPage source tab not shown in the Minerva skin.

The "Source" tab is currently inserted using javascript ("modules/article/ext.proofreadpage.article.js"). It might be possible to use the same trick for Minerva. But migrating everything to PHP would be nicer.

Jun 8 2021, 7:14 AM · MinervaNeue (Tracking), Mobile, ProofreadPage
Tpt added a comment to T284504: ProofreadPages: Allow <pages/> tag on index pages.

@Tpt Is there a technical reason for this?

Jun 8 2021, 4:46 AM · ProofreadPage

May 22 2021

Tpt closed T268932: Add Bengali currency/hexadecimal numerals to pagelist as Resolved.

Done and deployed

May 22 2021, 1:43 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Bengali-Sites, I18n, ProofreadPage
Tpt added a comment to T279255: GSoC 2021 Proposal: Add zoom and pan to the Wikisource Pagelist Widget.

Sorry for stepping in. A maybe relevant task when designing a new zooming system: T43614

May 22 2021, 12:53 PM · Patch-For-Review, ProofreadPage, Google-Summer-of-Code (2021)

Mar 27 2021

Tpt added a comment to T93608: Switch ProofreadPage to use indicator tags.

@He7d3r @GOIII are you fine with me closing this task as "declined" or do you want to move this forward, maybe by getting feedback from the Wikisource community?

Mar 27 2021, 12:35 PM · ProofreadPage
Tpt added a comment to T93608: Switch ProofreadPage to use indicator tags.

After thinking a little bit (and asking my wife who does not contribute to Wikisource), I have a feeling using an indicator is maybe not highlighting enough the proofreading level information: it's the first thing people are often looking for if they go to a page: page. But I am not an UX design expert so maybe an indicator is good enough.

Mar 27 2021, 8:03 AM · ProofreadPage
Tpt added a comment to T93608: Switch ProofreadPage to use indicator tags.

Thank you for pushing this. I am a bit afraid it might create a backlash with some contributors feeling that the proofreading level is not highlighted enough. It might be nice to start a discussion on the biggest Wikisource communities. A first step is maybe to move the quality level from the <pages> tag and in the Index namespaces to an indicator.

Mar 27 2021, 7:54 AM · ProofreadPage
Tpt added a comment to T53980: Source tab not showing up in the Translation namespace.

This is presumably very nearly T239033, since if the extension can add a "Source" link for a mainspace page user of <pages/>, it can do it in any other namespace?

Mar 27 2021, 7:26 AM · ProofreadPage
Tpt added a comment to T239033: Make ProofreadPage insert the "Source" link server side in the main namespace.

@Inductiveload Yes, I guess it should be also done in onSkinTemplateNavigation. The tricky part is that the "source" link is not known from the current page title but from the parser output, and onSkinTemplateNavigation do not have access to the parser output. It's why I have not done the migration to server side yet. There is maybe a good solution, I have not taken much time to look for an alternative yet.

Mar 27 2021, 7:24 AM · ProofreadPage

Mar 26 2021

Tpt moved T278564: Codesniffer should warn if output functions like print are used from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mar 26 2021, 4:33 PM · phan, MediaWiki-Codesniffer
Tpt created T278564: Codesniffer should warn if output functions like print are used.
Mar 26 2021, 4:33 PM · phan, MediaWiki-Codesniffer

Mar 25 2021

Tpt added a comment to T215165: Allow an individual CSS page for any book.

@Tpt, is that fix complete or is there more that needs to be considered.

Mar 25 2021, 3:52 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), TemplateStyles, ProofreadPage, All-and-every-Wikisource
Tpt added a comment to T215165: Allow an individual CSS page for any book.

@Inductiveload https://gerrit.wikimedia.org/r/672760 generated "null pointer exceptions" during Page: pages rendering if the page was not already connected to an index (trace in T278379). Antoine and I reverted the change to fix this error. It was the simplest way we found to fix this error quickly on Wikisource, sorry. I have started to write a change that should fix this problem: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/674691/1/includes/Page/PageContent.php
Feel free to integrate it into your change and push it again to gerrit.
Sorry again the quick revert.

Mar 25 2021, 12:33 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), TemplateStyles, ProofreadPage, All-and-every-Wikisource

Mar 19 2021

Tpt added a comment to T267617: Index page's page links should have the page index-in-file in them (e.g. as attribute).

@Tpt: hmm, but how will you then get the prp-pagequality-N qualityN classes applied? Or do that manually?

It should be automatically as part by the LinkRenderer: the classes are added by a linker hook.

Mar 19 2021, 1:56 PM · Patch-For-Review, ProofreadPage
Tpt added a comment to T267617: Index page's page links should have the page index-in-file in them (e.g. as attribute).

@Inductiveload I believe we could switch <pagelist> rendering to outputting HTML. $parser->getLinkRenderer()->makeLink allows to easily reuse MediaWiki linking system.

Mar 19 2021, 8:27 AM · Patch-For-Review, ProofreadPage

Mar 18 2021

Tpt updated the task description for T269609: Ensure all ToolsDB databases comply with current naming conventions.
Mar 18 2021, 8:42 PM · cloud-services-team (Kanban), Data-Services
Tpt added a comment to T277283: Add Index namespace on enWS to the $wgTemplateStylesNamespaces list.

@Inductiveload Yes, ProofreadPageInit.php is a good place for that.

Mar 18 2021, 10:20 AM · All-and-every-Wikisource, Wikimedia-Site-requests

Mar 16 2021

Tpt added a comment to T215165: Allow an individual CSS page for any book.

Not sure if that's a use case that is needed?

Mar 16 2021, 3:10 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), TemplateStyles, ProofreadPage, All-and-every-Wikisource
Tpt added a comment to T215165: Allow an individual CSS page for any book.

@Inductiveload I believe it should be better to use templatestyle because it does a lot of nice and useful CSS transformation and sanitization.

Mar 16 2021, 1:41 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), TemplateStyles, ProofreadPage, All-and-every-Wikisource

Mar 9 2021

Tpt closed T276881: WSexport: Harmonize format options between the download button and the sidebar as Resolved.
Mar 9 2021, 9:36 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Community-Tech, WS Export, All-and-every-Wikisource
Tpt created T276881: WSexport: Harmonize format options between the download button and the sidebar.
Mar 9 2021, 7:34 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Community-Tech, WS Export, All-and-every-Wikisource

Mar 8 2021

Samwilson awarded T276418: WS export: Wikisource editors should have an easy way to bypass the cache a Like token.
Mar 8 2021, 7:13 AM · All-and-every-Wikisource, Community-Tech, WS Export

Mar 4 2021

Tpt created T276418: WS export: Wikisource editors should have an easy way to bypass the cache.
Mar 4 2021, 7:23 AM · All-and-every-Wikisource, Community-Tech, WS Export
Tpt created T276416: Auto close the "download" dialog after download.
Mar 4 2021, 7:15 AM · All-and-every-Wikisource, WS Export

Feb 19 2021

Tpt closed T275190: "Index:" namespace pages on test2.wikipedia.org not working, show only "Avancement inconnu" etc as Resolved.
Feb 19 2021, 11:33 AM · WMF-General-or-Unknown
Tpt updated subscribers of T275190: "Index:" namespace pages on test2.wikipedia.org not working, show only "Avancement inconnu" etc.

@Aklapper @jayantanth Sorry for this problem. It's now fixed. I have changed the "index template" to allow @Tshrinivasan to play with Index: template rendring using Lua modules.

Feb 19 2021, 11:33 AM · WMF-General-or-Unknown

Jan 22 2021

Tpt added a comment to T271869: Wikisource Ebooks: Implement New Download Experience (first iteration).

Why is MOBI described as being for Calibre? I would've thought EPUB would be closer to Calibre's "default" format.

Jan 22 2021, 8:42 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Community-Tech (Kanban-2020-21-Q3), WS Export

Jan 21 2021

Tpt closed T272163: Install the Wikisource extension on oldwikisource as Resolved.
Jan 21 2021, 8:11 PM · All-and-every-Wikisource, Wikimedia-Site-requests

Jan 20 2021

Tpt added a comment to T272163: Install the Wikisource extension on oldwikisource.

@Urbanecm Sure. Here it is: https://wikisource.org/wiki/Wikisource:Scriptorium#MediaWiki_Wikisource_extension_installation

Jan 20 2021, 8:32 PM · All-and-every-Wikisource, Wikimedia-Site-requests
Tpt closed T258484: It should be possible to hide the navigation links in Special:IndexPage as Resolved.
Jan 20 2021, 7:46 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), good first task, ProofreadPage, All-and-every-Wikisource
Tpt added a comment to T258484: It should be possible to hide the navigation links in Special:IndexPage.

@Yash9265 wrote a change that removes navigation links when transcluding Special:IndexPages. I believe this problem is now solved.

Jan 20 2021, 7:46 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), good first task, ProofreadPage, All-and-every-Wikisource
Tpt added a comment to T272440: WS Export: Only show export links on certain namespaces.

I believe we want to display the export links only in namespaces where ProofreadPage allows the transclusion to happen and displays its navigation links.
For now it's only the main namespace but some Wikisource requested to be able to use it in other namespace (T53980).
Possible way to fix both problems at the same time is maybe create a per-wiki config inside of ProofreadPage and reuse it for the Wsexport link.

Jan 20 2021, 6:45 AM · Community-Tech, WS Export

Jan 15 2021

Tpt added a project to T272163: Install the Wikisource extension on oldwikisource: All-and-every-Wikisource.
Jan 15 2021, 4:37 PM · All-and-every-Wikisource, Wikimedia-Site-requests
Tpt added a comment to T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension.

We don't show the links on https://wikisource.org. I don't know if this matters. I don't know if users use that site.

Jan 15 2021, 4:36 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Community-Tech (Kanban-2020-21-Q3), WS Export
Tpt created T272163: Install the Wikisource extension on oldwikisource.
Jan 15 2021, 4:35 PM · All-and-every-Wikisource, Wikimedia-Site-requests

Jan 13 2021

Tpt closed T268906: Add Thai numerals to pagelist as Resolved.

The change adding "thai" numerals support is now deployed on Wikisource.

Jan 13 2021, 8:18 PM · Thai-Sites, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), I18n, ProofreadPage, All-and-every-Wikisource
Tpt reopened T268932: Add Bengali currency/hexadecimal numerals to pagelist as "Open".

Sorry, I confused this task with an other one.

Jan 13 2021, 8:17 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Bengali-Sites, I18n, ProofreadPage
Tpt closed T268932: Add Bengali currency/hexadecimal numerals to pagelist as Resolved.
Jan 13 2021, 8:16 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Bengali-Sites, I18n, ProofreadPage
Tpt added a comment to T258192: Wikisource: footnote links do not work for large books.

My 2 cents: I like the idea of using Calibre ePub to ePub to do the file split in case of too big files. The current implementation in Wsexport is very bad. An other option would be to fix it inside of Wsexport by having a look of what Calibre is actually doing internally.

Jan 13 2021, 8:01 PM · WS Export, All-and-every-Wikisource, Community-Tech
Tpt updated the task description for T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension.
Jan 13 2021, 4:15 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Community-Tech (Kanban-2020-21-Q3), WS Export
Tpt updated the task description for T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension.
Jan 13 2021, 4:11 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Community-Tech (Kanban-2020-21-Q3), WS Export

Jan 10 2021

Tpt added a comment to T232477: Placement of pagenum span on page-spanning tables.

So, the question is: Can the ProofreadPage extension be smarter about where the pagenum template is inserted to avoid putting it in "dead" table space?

Jan 10 2021, 2:54 PM · ProofreadPage

Dec 16 2020

Tpt created T270337: "sql tools" returns "connection refused" from freebase tool.
Dec 16 2020, 7:44 PM · Data-Services

Dec 2 2020

Tpt added a comment to T268424: Wikisource: Reinstate OPDS export.

Thank you! It looks like a great plan!

Dec 2 2020, 7:03 AM · Community-Tech (Kanban-2020-21-Q3), WS Export