Tpt (Tpt)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:56 AM (217 w, 6 d)
Availability
Available
IRC Nick
Tpt
LDAP User
Tpt
MediaWiki User
Tpt [ Global Accounts ]

Recent Activity

Thu, Dec 6

Tpt renamed T211314: Makes WIkisource DoubleWiki.js script part of the DoubleWiki extension from Makes WIkisource DoubleWiki.js scrit part of the DoubleWiki extension to Makes WIkisource DoubleWiki.js script part of the DoubleWiki extension.
Thu, Dec 6, 10:37 AM · Wikisource, MediaWiki-extensions-DoubleWiki
Tpt created T211314: Makes WIkisource DoubleWiki.js script part of the DoubleWiki extension.
Thu, Dec 6, 10:37 AM · Wikisource, MediaWiki-extensions-DoubleWiki

Thu, Nov 29

Tpt edited parent tasks for T146160: Migrate ProofreadPage zoom feature to OOJS, added: T100270: Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core; removed: T122014: Convert all extensions/skins to OOUI.
Thu, Nov 29, 9:22 PM · Patch-For-Review, ProofreadPage
Tpt added a subtask for T100270: Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core: T146160: Migrate ProofreadPage zoom feature to OOJS.
Thu, Nov 29, 9:22 PM · Epic, OOUI, UI-Standardization
Tpt removed a subtask for T122014: Convert all extensions/skins to OOUI: T146160: Migrate ProofreadPage zoom feature to OOJS.
Thu, Nov 29, 9:22 PM · Goal, UI-Standardization
Tpt added a parent task for T146160: Migrate ProofreadPage zoom feature to OOJS: T122014: Convert all extensions/skins to OOUI.
Thu, Nov 29, 9:21 PM · Patch-For-Review, ProofreadPage
Tpt added a subtask for T122014: Convert all extensions/skins to OOUI: T146160: Migrate ProofreadPage zoom feature to OOJS.
Thu, Nov 29, 9:21 PM · Goal, UI-Standardization
Tpt closed T210672: Convert Extension:ProofreadPage to use OOUI as Resolved.

I believe everything has been converted. We still have T146160 opened, but it's not related to HTML input elements.

Thu, Nov 29, 9:20 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), ProofreadPage, UI-Standardization, User-Jayprakash12345
Tpt closed T210672: Convert Extension:ProofreadPage to use OOUI, a subtask of T122014: Convert all extensions/skins to OOUI, as Resolved.
Thu, Nov 29, 9:20 PM · Goal, UI-Standardization
Tpt added a comment to T208711: Update the "tesseract-ben" package on Toolforge for OCR on Bengali Wikisource.

@bd808 Thank you very much for having had a look at it! I believe that waiting for Stretch deployment is indeed the easiest way to go.

Thu, Nov 29, 9:07 PM · Indic-TechCom, Toolforge, Wikisource, Bengali-Sites

Tue, Nov 27

Tpt updated the task description for T210174: Deploy Wikisource extension to Wikimedia cluster.
Tue, Nov 27, 6:51 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Wikisource
Tpt added projects to T210174: Deploy Wikisource extension to Wikimedia cluster: Wikimedia-Extension-setup, Wikimedia-extension-review-queue.
Tue, Nov 27, 6:49 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Wikisource

Thu, Nov 22

Tpt added a comment to T180303: Uses P629 (edition of) to add Wikipedia link in the other projects sidebar of Wikisource.

For this task to be done, the extension should be deployed on Wikisource: T210174

Thu, Nov 22, 6:45 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, MediaWiki-extensions-WikimediaBadges, Wikisource, Wikidata
Tpt created T210174: Deploy Wikisource extension to Wikimedia cluster.
Thu, Nov 22, 6:44 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Wikisource

Wed, Nov 21

Tpt committed rEWSO376b5870f59b: Uses the sitelinks from the work item in the other projects sidebar (authored by Tpt).
Uses the sitelinks from the work item in the other projects sidebar
Wed, Nov 21, 10:47 AM

Tue, Nov 20

Tpt added a comment to T209939: Convert Proofpage WE layout to use display flex.

Great idea! I'll be very happy to +2 a change.

Tue, Nov 20, 12:50 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), CSS, ProofreadPage

Mon, Nov 19

Tpt committed R2221:dd31f61b4503: Makes ws2wd support all Wikisource (authored by Tpt).
Makes ws2wd support all Wikisource
Mon, Nov 19, 8:45 PM

Sat, Nov 17

Tpt added a comment to T183950: Search and replace is totally broken when using it with ProofreadPage.

@TheDJ getSelection is overrided to support Wikitext to VE switch. We should definitely make header/footer compatible with textSelection. I have not taken time to implement this change yet. But if someone could write it, it would be much appreciated.

Sat, Nov 17, 8:51 AM · Wikisource, WikiEditor, ProofreadPage

Nov 10 2018

Tpt committed rEWSO852985f8d6f9: Uses the sitelinks from the work item in the other projects sidebar (authored by Tpt).
Uses the sitelinks from the work item in the other projects sidebar
Nov 10 2018, 11:14 AM
Tpt committed rEWSO82095c514af2: Uses the sitelinks from the work item in the other projects sidebar (authored by Tpt).
Uses the sitelinks from the work item in the other projects sidebar
Nov 10 2018, 11:11 AM
Tpt committed rEWSO43fdde376b1d: Uses the sitelinks from the work item in the other projects sidebar (authored by Tpt).
Uses the sitelinks from the work item in the other projects sidebar
Nov 10 2018, 11:03 AM
Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

I just had a quick review of the current GraphQL structure for Wikibase entities. It looks great! Thank you!

Nov 10 2018, 9:32 AM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata

Nov 7 2018

Tpt added a comment to T165837: Compute smart defaults when no latitude and longitude is given.

Thanks! The current task seems to duplicate that one indeed.

Nov 7 2018, 7:06 PM · Maps (Kartographer)
Tpt merged T165837: Compute smart defaults when no latitude and longitude is given into T158919: Enable auto-positioned snapshot on Kartographer side.
Nov 7 2018, 7:05 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Maps (Kartotherian)
Tpt merged task T165837: Compute smart defaults when no latitude and longitude is given into T158919: Enable auto-positioned snapshot on Kartographer side.
Nov 7 2018, 7:05 PM · Maps (Kartographer)

Oct 25 2018

Tpt updated the task description for T207986: Remove classic edit toolbar support from ProofreadPage.
Oct 25 2018, 8:09 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), MediaWiki-Page-editing, Wikisource, ProofreadPage
Tpt created T207986: Remove classic edit toolbar support from ProofreadPage.
Oct 25 2018, 8:09 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), MediaWiki-Page-editing, Wikisource, ProofreadPage

Oct 16 2018

Tpt added a comment to T207168: Provide JSON-LD support for Wikidata.

So you're not really asking for a change in the JSON-LD, you're asking for wikidata to only emit a single entity on the /entity/* endpoint -- and that would/could apply to all the different representations using the purtle backend. That's not a JSON-LD specific request.

Oct 16 2018, 8:26 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Wikidata, MediaWiki-extensions-WikibaseRepository
Tpt added a comment to T207168: Provide JSON-LD support for Wikidata.

@daniel We could do something similar for stubs. with structures like:

Oct 16 2018, 3:55 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Wikidata, MediaWiki-extensions-WikibaseRepository
Tpt added a comment to T207168: Provide JSON-LD support for Wikidata.

Not a problem but a cosmetic proposal: Instead of having the structure:

Oct 16 2018, 2:39 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Wikidata, MediaWiki-extensions-WikibaseRepository
Tpt added a comment to T206531: ProofreadPage doesn't pass ExtensionJsonValidationTest::testPassesValidation for mainfest_version 2.

@Reedy Should we close this task? The related change have been merged

Oct 16 2018, 10:19 AM · ProofreadPage
Tpt added a project to T207142: Make Proofreadpage_index_data_config more robustly localizable: Wikisource.
Oct 16 2018, 10:18 AM · Wikisource, ProofreadPage

Oct 15 2018

Tpt added a member for GraphQL: Tpt.
Oct 15 2018, 12:40 PM
Tpt added a watcher for GraphQL: Tpt.
Oct 15 2018, 12:40 PM

Oct 9 2018

Tpt merged T206520: Change ProofreadPage's PageDifferenceEngine to use SlotDiffRenderer into T204875: Diff on mobile not working for Wikisource.org pages .
Oct 9 2018, 11:53 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend, ProofreadPage, Wikimedia-production-error
Tpt merged task T206520: Change ProofreadPage's PageDifferenceEngine to use SlotDiffRenderer into T204875: Diff on mobile not working for Wikisource.org pages .
Oct 9 2018, 11:53 AM · Multi-Content-Revisions, Core Platform Team (MCR), ProofreadPage
Tpt updated the task description for T206519: <dynamicpagelist> outputs escaped HTML hen the addfirstcategorydate option is set to "dm".
Oct 9 2018, 10:15 AM · DynamicPageList (Wikimedia), Patch-For-Review
Tpt created T206519: <dynamicpagelist> outputs escaped HTML hen the addfirstcategorydate option is set to "dm".
Oct 9 2018, 10:14 AM · DynamicPageList (Wikimedia), Patch-For-Review

Oct 3 2018

Tpt added a comment to T165837: Compute smart defaults when no latitude and longitude is given.

For example if the call to mapframe is:

Oct 3 2018, 6:35 PM · Maps (Kartographer)

Sep 21 2018

Tpt added a comment to T160259: [Story] RDF for Lexemes, Forms and Senses.

It seems to me that the only thing missing in the implementation compared to https://www.mediawiki.org/wiki/Extension:WikibaseLexeme/RDF_mapping is the addition of schema:inLanguage for Lexemes. But it is derived data so it should not block the deployment to query.wikidata.org.

Sep 21 2018, 8:00 AM · Lexicographical data, Wikidata
Tpt closed T200901: [Task] Implement RDF serialization for senses as Resolved.

Yes

Sep 21 2018, 7:56 AM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Lexicographical data, Wikidata
Tpt closed T200901: [Task] Implement RDF serialization for senses, a subtask of T160259: [Story] RDF for Lexemes, Forms and Senses, as Resolved.
Sep 21 2018, 7:56 AM · Lexicographical data, Wikidata

Sep 19 2018

Tpt added a comment to T204024: Store WikibaseQualityConstraint check data in persistent storage instead of in the cache.

Thank you @Pintoch for raising this idea. For my fixing constraints violations project, I can mine violations from history offline so I do not really need this feature.

Sep 19 2018, 3:03 PM · Dependency-Tracking, Operations, Core Platform Team Backlog (Designing), Cassandra, Services (designing), wikidata-tech-focus, Wikidata-Campsite, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Sep 14 2018

Tpt added a comment to T204267: Flood of WDQS requests from wbqc.

@Jonas Thank you for your feedback.

Sep 14 2018, 3:24 PM · Cloud-Services, Operations, User-Addshore, Wikibase-Quality, Wikidata, Wikidata-Query-Service, Wikibase-Quality-Constraints
Tpt added a comment to T204267: Flood of WDQS requests from wbqc.

Sorry everyone for the troubles. I was experimenting with a tool that tries to find corrections for constraint violations.
I have modified it to send a proper User-Agent for all its requests to the Wikidata API but not restarted it.

Sep 14 2018, 2:13 PM · Cloud-Services, Operations, User-Addshore, Wikibase-Quality, Wikidata, Wikidata-Query-Service, Wikibase-Quality-Constraints

Sep 4 2018

Tpt committed rEWLE0cd03f292a6d: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Sep 4 2018, 11:47 AM
Tpt committed rEWLE667e2b68b55f: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by Tpt).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Sep 4 2018, 11:47 AM
Tpt committed rEWLEba8cd39f9fb1: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by Tpt).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Sep 4 2018, 11:42 AM
Tpt committed rEWLEb1db6be58d07: Merge "ViewTests: use mock entity id formatter" (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).
Merge "ViewTests: use mock entity id formatter"
Sep 4 2018, 11:42 AM

Aug 30 2018

Tpt committed rEWLE0663db289ecd: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by Tpt).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Aug 30 2018, 6:06 PM

Aug 25 2018

Tpt committed rEWLE56c44f19fc82: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by Tpt).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Aug 25 2018, 7:08 PM

Aug 23 2018

Tpt added a comment to T200901: [Task] Implement RDF serialization for senses.

I would wait for addition of proper statement serialization that is tracked by T195043.

Aug 23 2018, 7:14 AM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Lexicographical data, Wikidata

Aug 22 2018

Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

With that.. I think it would be best if we moved your code to a new "graphql" repo, host the GraphQL server on a Cloud VPS, and then rewrite it in JavaScript (node.js) so it's as fast as it can be. If it gets enough usage we can talk about moving it onto production. :) What do you think? does that sound like a plan?

Aug 22 2018, 6:43 AM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata

Aug 21 2018

Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

For statement filtering by qualifier a good solution is maybe to add an extra parameter "hasStatement" to the statements field and give to it a value of type SnakInput (a GraphQL input type that would be used to encode a snak provided by the GraphQL client). What do you think about it?

So it looks like the proper way to do this is with a Directive. Then again, I'm not really sure I understand the difference between Directives and Arguments. Perhaps arguments can only be used on objects and Directives can be used on any type?

Aug 21 2018, 12:33 PM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata
Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

@dbarratt Thank you for planning to work on Wikibase+GraphQL.

Aug 21 2018, 6:48 AM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata

Aug 15 2018

Tpt added a comment to T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array..

@Ankry the fix is planned to be deployed soon. Have some real pages still affected is a good way to check that the problem is indeed solved.

Aug 15 2018, 6:53 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-production-error, ProofreadPage

Aug 10 2018

Tpt added a comment to T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array..

@Tpt any idea how can we create propoer header/footer here (if this is the source of the problem)?

Aug 10 2018, 9:06 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-production-error, ProofreadPage

Aug 8 2018

Tpt added a comment to T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array..

It seems that the two pages could be parsed as JSON by PHP and so, ProofreadPage assumes that they are using the JSON serialization for Page: pages. But, because they are not using the good JSON serialization format, an exception is thrown.

Aug 8 2018, 1:36 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-production-error, ProofreadPage
Tpt committed rEWLEf8f5c3528a38: Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and… (authored by Tpt).
Uses EntityMentionListener::subEntityMentioned to properly serialize Forms and…
Aug 8 2018, 6:29 AM

Aug 4 2018

Tpt added a comment to T201109: Raw HTML message in ProofreadPage.

I have just made a change that uses LinkRender instead of Linker and, so, should fix the possible XSS injection https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ProofreadPage/+/450398/

Aug 4 2018, 3:03 PM · ProofreadPage, Security, phan-taint-check-plugin

Aug 3 2018

Tpt added a comment to T201109: Raw HTML message in ProofreadPage.

I also checked about the potential SQLi and I don't see how it could happen. All "conds" arguments are key-values where the key is a string so should be properly escaped. More values seems to always be an integer or an array of DBKey obtained by using the Title::getDBKey method. The error are maybe raised because the query is constructed in a different class than the one where the execution is called.

Aug 3 2018, 7:19 AM · ProofreadPage, Security, phan-taint-check-plugin

Aug 2 2018

Tpt added a comment to T195043: [Task] Implement RDF serialization for lexemes and forms.

Also, I understand it's still disabled on both wikidata and test.wikidata.

Aug 2 2018, 5:31 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Lexicographical data, Wikidata
Tpt added a comment to T195043: [Task] Implement RDF serialization for lexemes and forms.

There is still one feature missing: outputting statements on form and senses when the RDF representation of a lexeme is required (e.g. on Special:EntityData/L12.nt).

Aug 2 2018, 5:26 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Lexicographical data, Wikidata
Tpt committed rEWLE93574c649428: Implements RDF mapping of senses including stubs (authored by Tpt).
Implements RDF mapping of senses including stubs
Aug 2 2018, 5:25 PM
Tpt added a comment to T200901: [Task] Implement RDF serialization for senses.

Is https://gerrit.wikimedia.org/r/449718 covering this?

Aug 2 2018, 5:24 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Lexicographical data, Wikidata

Aug 1 2018

Tpt committed rEWLE4ea0547e79d2: Implements RDF mapping of senses including stubs (authored by Tpt).
Implements RDF mapping of senses including stubs
Aug 1 2018, 1:48 PM
Tpt committed rEWLE6d224ea24bd6: Implements RDF mapping of senses including stubs (authored by Tpt).
Implements RDF mapping of senses including stubs
Aug 1 2018, 1:32 PM
Tpt added a parent task for T200901: [Task] Implement RDF serialization for senses: T160259: [Story] RDF for Lexemes, Forms and Senses.
Aug 1 2018, 1:31 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Lexicographical data, Wikidata
Tpt added a subtask for T160259: [Story] RDF for Lexemes, Forms and Senses: T200901: [Task] Implement RDF serialization for senses.
Aug 1 2018, 1:31 PM · Lexicographical data, Wikidata
Tpt created T200901: [Task] Implement RDF serialization for senses.
Aug 1 2018, 1:30 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Lexicographical data, Wikidata

Jul 28 2018

Tpt committed R2221:cd4f39808147: Minor variable renaming (authored by Tpt).
Minor variable renaming
Jul 28 2018, 9:32 AM
Tpt committed R2221:3e7788dafdca: Upgrades dependencies and sets min PHP version to 5.6 (authored by Tpt).
Upgrades dependencies and sets min PHP version to 5.6
Jul 28 2018, 9:32 AM

Jul 27 2018

Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

Indeed the set of property and their datatypes is very static and cachable so we could use them as keys of a StatementByProperty object and then have StringStatement, StringSnak... types. The object would just be huge and maybe raise some performance problems of the various GraphQL tools (we would have 4K+ keys).

Jul 27 2018, 6:24 PM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata

Jul 21 2018

Tpt closed D1082: CORS Preflight causes a PHP Fatal Error.
Jul 21 2018, 3:46 PM
Tpt accepted D1082: CORS Preflight causes a PHP Fatal Error.

Thanks!

Jul 21 2018, 3:46 PM
Tpt committed R2221:ff28c8877723: Applies https://phabricator.wikimedia.org/D1082 (authored by Tpt).
Applies https://phabricator.wikimedia.org/D1082
Jul 21 2018, 3:46 PM
Tpt closed D1081: Add CORS Header.

Deployed

Jul 21 2018, 12:39 PM
Tpt committed R2221:c2cae8f111b8: Applies https://phabricator.wikimedia.org/D1081 (authored by Tpt).
Applies https://phabricator.wikimedia.org/D1081
Jul 21 2018, 12:39 PM
Tpt added a comment to D1081: Add CORS Header.

Thank you!

Jul 21 2018, 12:34 PM
Tpt accepted D1081: Add CORS Header.
Jul 21 2018, 12:34 PM
Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

Thank you!

Jul 21 2018, 8:34 AM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata
Tpt added a comment to T173214: Support GraphQL Queries across Wikimedia.

@Tpt so it looks like right now you can't get a datavalue or recursively call item from a statement. I added a sample query to the task description.

Jul 21 2018, 7:26 AM · Patch-For-Review, Developer-Wishlist, MediaWiki-extensions-WikibaseRepository, Wikidata.org, Wikidata

Jul 14 2018

Tpt closed T143029: Remove use of jquery.tipsy in ProofreadPage as Resolved.

Done as part of T153120

Jul 14 2018, 7:20 AM · Technical-Debt, ProofreadPage, JavaScript
Tpt closed T143029: Remove use of jquery.tipsy in ProofreadPage, a subtask of T69500: jquery.tipsy (tracking), as Resolved.
Jul 14 2018, 7:20 AM · MediaWiki-Interface, JavaScript, Tracking
Tpt closed T143029: Remove use of jquery.tipsy in ProofreadPage, a subtask of T117720: Remove use of jquery.tipsy from Wikimedia-maintained code, as Resolved.
Jul 14 2018, 7:20 AM · Technical-Debt, JavaScript, MediaWiki-General-or-Unknown

Jul 13 2018

Tpt added a comment to T199288: For anonymous users the Index namespace pages are not displaying "page status" in desktop view ($wgTitle not set in GetLinkColours hook).

@Billinghurst Is the problem still happening now that the quality color bug is solved?

Jul 13 2018, 7:52 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), ProofreadPage
Tpt committed R2221:816f6b0cedfa: Backward compatibility with PHP 5.5 (authored by Tpt).
Backward compatibility with PHP 5.5
Jul 13 2018, 11:18 AM
Tpt committed R2221:d0b56be1fb12: Do not escape HTML entities in the page title (authored by Tpt).
Do not escape HTML entities in the page title
Jul 13 2018, 11:14 AM
Tpt committed R2221:5f5ddb6969ec: Upgrades GraphQlRelay library (authored by Tpt).
Upgrades GraphQlRelay library
Jul 13 2018, 11:14 AM
Tpt committed R2221:202925347cf4: Upgrades MediaWiki codesniffer (authored by Tpt).
Upgrades MediaWiki codesniffer
Jul 13 2018, 11:14 AM

Jul 12 2018

Tpt closed T198470: page proofread status is not displayed in index page for some pages as Resolved.

The fallback to the categories seems to work. I plan to keep it as long as their exists Page: pages that do not contain the pageproperty

Jul 12 2018, 7:00 AM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage

Jul 11 2018

Tpt added a comment to T198470: page proofread status is not displayed in index page for some pages.

Sorry, I was wrong, the fix is not deployed yet. It should be deployed this evening UTC.

Jul 11 2018, 9:54 AM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage
Tpt added a comment to T199288: For anonymous users the Index namespace pages are not displaying "page status" in desktop view ($wgTitle not set in GetLinkColours hook).

As a logged-in user, it will also show normally/as expected.

Jul 11 2018, 7:18 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), ProofreadPage

Jul 10 2018

Tpt added a comment to T198470: page proofread status is not displayed in index page for some pages.

@Tpt it does not seem to work: https://fr.wikisource.org/wiki/Livre:Revue_du_monde_nouveau,_vol._I,_1874.djvu

Jul 10 2018, 5:51 PM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage
Tpt added a comment to T198470: page proofread status is not displayed in index page for some pages.

The change that should fix this problem have been deployed yesterday. A purge of the pages where blank ids are displayed should fix the problem (for Index: pages it could be done with a not null edit on MediaWiki:Proofreadpage_index_template)

Jul 10 2018, 5:32 PM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage

Jul 7 2018

Tpt merged T198998: prop=proofread returns different content for different pages into T198470: page proofread status is not displayed in index page for some pages.
Jul 7 2018, 2:50 PM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage
Tpt merged task T198998: prop=proofread returns different content for different pages into T198470: page proofread status is not displayed in index page for some pages.
Jul 7 2018, 2:50 PM · MediaWiki-API, ProofreadPage
Tpt added a comment to T198998: prop=proofread returns different content for different pages.

This is a side effect of T198470. A fix for it should be deployed next week.

Jul 7 2018, 2:50 PM · MediaWiki-API, ProofreadPage

Jun 30 2018

Tpt added a comment to T198470: page proofread status is not displayed in index page for some pages.

Fallback have been implemented and merged into ProofreadPage. It is live now on https://en.wikisource.beta.wmflabs.org and will be deployed on Wikisources next Tuesday.

Jun 30 2018, 11:11 AM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage
Tpt added a comment to T198470: page proofread status is not displayed in index page for some pages.

@Ankry here is the query you are looking for: https://quarry.wmflabs.org/query/27922

Jun 30 2018, 9:56 AM · Wikisource, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, ProofreadPage