Page MenuHomePhabricator
Create Task
Maniphest T289728

ProofreadPage\PageNumberNotFoundException: Page:[page] provides invalid page number
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   ProofreadPage\PageNumberNotFoundException: Page:Biriukov - Léon Tolstoï, vie et oeuvre 3.djvu/ provides invalid page number
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.20/extensions/ProofreadPage/includes/Pagination/FilePagination.php(70)
#0 /srv/mediawiki/php-1.37.0-wmf.20/extensions/ProofreadPage/includes/ProofreadPage.php(378): ProofreadPage\Pagination\FilePagination->getPageNumber(Title)
#1 /srv/mediawiki/php-1.37.0-wmf.20/extensions/ProofreadPage/includes/ProofreadPage.php(508): ProofreadPage\ProofreadPage::addPageNsNavigation(Title, SkinVector, array)
#2 /srv/mediawiki/php-1.37.0-wmf.20/includes/HookContainer/HookContainer.php(338): ProofreadPage\ProofreadPage::onSkinTemplateNavigationUniversal(SkinVector, array)
#3 /srv/mediawiki/php-1.37.0-wmf.20/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#4 /srv/mediawiki/php-1.37.0-wmf.20/includes/HookContainer/HookRunner.php(3474): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#5 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinTemplate.php(922): MediaWiki\HookContainer\HookRunner->onSkinTemplateNavigation__Universal(SkinVector, array)
#6 /srv/mediawiki/php-1.37.0-wmf.20/skins/Vector/includes/SkinVector.php(315): SkinTemplate->runOnSkinTemplateNavigationHooks(SkinVector, array)
#7 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinTemplate.php(1249): SkinVector->runOnSkinTemplateNavigationHooks(SkinVector, array)
#8 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinMustache.php(207): SkinTemplate->buildContentNavigationUrls()
#9 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinMustache.php(199): SkinMustache->getPortletsTemplateData()
#10 /srv/mediawiki/php-1.37.0-wmf.20/skins/Vector/includes/SkinVector.php(326): SkinMustache->getTemplateData()
#11 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinMustache.php(137): SkinVector->getTemplateData()
#12 /srv/mediawiki/php-1.37.0-wmf.20/includes/skins/SkinTemplate.php(150): SkinMustache->generateHTML()
#13 /srv/mediawiki/php-1.37.0-wmf.20/includes/OutputPage.php(2644): SkinTemplate->outputPage()
#14 /srv/mediawiki/php-1.37.0-wmf.20/includes/MediaWiki.php(939): OutputPage->output(boolean)
#15 /srv/mediawiki/php-1.37.0-wmf.20/includes/MediaWiki.php(952): MediaWiki::{closure}()
#16 /srv/mediawiki/php-1.37.0-wmf.20/includes/MediaWiki.php(559): MediaWiki->main()
#17 /srv/mediawiki/php-1.37.0-wmf.20/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-1.37.0-wmf.20/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Impact
Notes

Saw 13 of these soon after rollout of 1.37.0-wmf.20 (T281161) to group1.

They mostly seem to contain a / in the page name.

Details

Request URL
https://fr.wikisource.org/wiki/Page:[page]
SubjectRepoBranchLines +/-
Fixes exception thrown by FilePagination::getPageNumbermediawiki/extensions/ProofreadPagewmf/1.37.0-wmf.20+24 -2
Fixes exception thrown by FilePagination::getPageNumbermediawiki/extensions/ProofreadPagemaster+24 -2
Catch PageNumberNotFoundException in addPageNsNavigationmediawiki/extensions/ProofreadPagemaster+16 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

brennen triaged this task as Unbreak Now! priority.Aug 25 2021, 7:32 PM
brennen created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2021, 7:32 PM
brennen added a parent task: T281161: 1.37.0-wmf.20 deployment blockers.Aug 25 2021, 7:32 PM
brennen added projects: ProofreadPage, Vector (legacy skin), Platform Engineering.
Zabe subscribed.Aug 25 2021, 7:41 PM

rEPRPe7b6e4cbe4ef: Pagination system code cleanup seems to cause this.

Inductiveload claimed this task.Aug 25 2021, 7:49 PM
Jdlrobson edited projects, added Vector (legacy skin) (Tracking); removed Vector (legacy skin).Aug 25 2021, 7:56 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Aug 25 2021, 7:58 PM
brennen added a subscriber: dancy.

cc: @dancy

matmarex subscribed.Aug 25 2021, 8:10 PM
Tpt subscribed.Aug 25 2021, 8:18 PM

I'm working on a fix. Should be ready soon. Sorry for the troubles.

gerritbot added a comment.Aug 25 2021, 8:18 PM

Change 714829 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] Catch PageNumberNotFoundException in addPageNsNavigation

https://gerrit.wikimedia.org/r/714829

gerritbot added a project: Patch-For-Review.Aug 25 2021, 8:18 PM
gerritbot added a comment.Aug 25 2021, 8:20 PM

Change 714832 had a related patch set uploaded (by Tpt; author: Tpt):

[mediawiki/extensions/ProofreadPage@master] Fixes exception thrown by FilePagination::getPageNumber

https://gerrit.wikimedia.org/r/714832

Inductiveload mentioned this in T289734: Add test for missing exception hander in PageContent and addPageNsNavigation.Aug 25 2021, 8:21 PM
gerritbot added a comment.Aug 25 2021, 8:25 PM

Change 714829 abandoned by Inductiveload:

[mediawiki/extensions/ProofreadPage@master] Catch PageNumberNotFoundException in addPageNsNavigation

Reason:

Tpt has a more correct patch (throw the right exception in the first place)

https://gerrit.wikimedia.org/r/714829

Urbanecm reassigned this task from Inductiveload to Tpt.Aug 25 2021, 8:45 PM
Urbanecm added a subscriber: Inductiveload.
gerritbot added a comment.Aug 25 2021, 8:49 PM

Change 714682 had a related patch set uploaded (by Tpt; author: Tpt):

[mediawiki/extensions/ProofreadPage@wmf/1.37.0-wmf.20] Fixes exception thrown by FilePagination::getPageNumber

https://gerrit.wikimedia.org/r/714682

gerritbot added a comment.Aug 25 2021, 8:52 PM

Change 714832 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Fixes exception thrown by FilePagination::getPageNumber

https://gerrit.wikimedia.org/r/714832

gerritbot added a comment.Aug 25 2021, 8:59 PM

Change 714682 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@wmf/1.37.0-wmf.20] Fixes exception thrown by FilePagination::getPageNumber

https://gerrit.wikimedia.org/r/714682

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 25 2021, 9:00 PM
Stashbot added a comment.Aug 25 2021, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-25T21:03:13Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/ProofreadPage/: 913043a5ca7982e07ab0c01f88076af866a43cc3: Fixes exception thrown by FilePagination::getPageNumber (T289728) (duration: 01m 06s)

Urbanecm closed this task as Resolved.Aug 25 2021, 9:03 PM
Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 26 2021, 9:20 PM
dancy mentioned this in T281161: 1.37.0-wmf.20 deployment blockers.Aug 26 2021, 10:07 PM
Zabe removed a project: Patch-For-Review.Aug 30 2021, 10:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits