Page MenuHomePhabricator

Mpaa (Mpaa)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 24 2014, 11:18 PM (277 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Mpaa [ Global Accounts ]

Recent Activity

Wed, Feb 12

Mpaa assigned T243200: Move PAWS to OAuth 2.0 to Chicocvenancio.
Wed, Feb 12, 10:17 PM · Pywikibot-OAuth, Pywikibot-login.py, Pywikibot, PAWS
Mpaa placed T243200: Move PAWS to OAuth 2.0 up for grabs.

I will take care of implementing OAuth2 for pywikibot. Hope soon ...

Wed, Feb 12, 10:16 PM · Pywikibot-OAuth, Pywikibot-login.py, Pywikibot, PAWS
Mpaa added a comment to T244187: MW OAuth2 doesn't seem to work.

It works, thanks.

Wed, Feb 12, 10:06 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-extensions-OAuth

Fri, Feb 7

Mpaa added a comment to T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character.

@OlehOnyshchcak, thanks for the clarification. Appreciated!

Fri, Feb 7, 11:45 PM · Patch-For-Review, Pywikibot

Thu, Feb 6

Mpaa added a comment to T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character.

and also wasted me a lot of time in the process of realizing that I need to implement this and re-download data.

Thu, Feb 6, 9:21 PM · Patch-For-Review, Pywikibot

Mon, Feb 3

Chicocvenancio awarded T244187: MW OAuth2 doesn't seem to work a Heartbreak token.
Mon, Feb 3, 11:23 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-extensions-OAuth
Mpaa updated subscribers of T244187: MW OAuth2 doesn't seem to work.
Mon, Feb 3, 11:23 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-extensions-OAuth
Mpaa created T244187: MW OAuth2 doesn't seem to work.
Mon, Feb 3, 11:21 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-extensions-OAuth

Fri, Jan 31

Mpaa committed rPWBC6dba77de0028: [bugfix] Fix parameters in OauthLoginManager() (authored by Mpaa).
[bugfix] Fix parameters in OauthLoginManager()
Fri, Jan 31, 5:22 AM

Tue, Jan 28

Mpaa committed rPWBCddd61b0f5bc2: Remove AS_SYSOP from LoginStatus enum (authored by Mpaa).
Remove AS_SYSOP from LoginStatus enum
Tue, Jan 28, 11:24 PM

Fri, Jan 24

Mpaa added a comment to T225594: UserWarning: Site objects have been created before arguments were handled.

clear_sites dict after tests are done

Fri, Jan 24, 10:21 PM · Pywikibot, Pywikibot-tests
Mpaa added a comment to T173385: Unable to change Proofread status via API (pywikibot).

@Mpaa transferbot.py doesn't check the ql of the pages. The error is arisen by the API when you try to write the text.

I know, what I meant is that transferbot could be modified to check namespace / ql of pages and downgrade ql from 4 to 3 if no page exists at destination wiki, so the API would not throw the error you see.

Fri, Jan 24, 8:01 PM · Pywikibot, ProofreadPage

Thu, Jan 23

Mpaa added a comment to T173385: Unable to change Proofread status via API (pywikibot).

Actually I have been able to transfer a page with 3 quality level.
Example command: pwb.py transferbot -family:wikisource -lang:it -tolang:nap -page:'Pagina:Giuseppe Aliani, Educazione della donne 1922.djvu/75'

This is correct, because a page can be created directly with ql=3.

Thu, Jan 23, 8:31 PM · Pywikibot, ProofreadPage

Jan 16 2020

Mpaa added a comment to T173385: Unable to change Proofread status via API (pywikibot).

@Mpaa Well, the same happens without the option ql=4.

Jan 16 2020, 10:21 PM · Pywikibot, ProofreadPage

Jan 15 2020

Mpaa added a comment to T173385: Unable to change Proofread status via API (pywikibot).

I am not sure but in this case you are creating a new page in a different wiki, using an existing page with ql=4.
Probably it is trying to set ql=4 also in the new page, violating the rule about change of status Not Proofread->Proofread, Validated.
@Tpt, any opinion?
Maybe pywikibot could be smarter here and check?

Jan 15 2020, 11:26 PM · Pywikibot, ProofreadPage
Mpaa added a comment to T242425: Wikidata shows different image (file) sizes, than Commons reports for the current version.

Went back to both integers.
To me this is solved.

Jan 15 2020, 9:25 PM · MediaWiki-extensions-PdfHandler, Wikidata
Mpaa closed T242517: Thumbnails for PDF files not found when width is not an Integer in URL link as Resolved.

Seems OK to me.

Jan 15 2020, 9:22 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa added a comment to T242795: File deleted at Commons is no longer available even after page restore.

All pages:

Jan 15 2020, 9:18 PM · SRE-swift-storage, MediaWiki-File-management, Commons

Jan 14 2020

Mpaa added a project to T242795: File deleted at Commons is no longer available even after page restore: MediaWiki-File-management.
Jan 14 2020, 10:52 PM · SRE-swift-storage, MediaWiki-File-management, Commons
Mpaa added a comment to T241413: A lot of wikisource urls are redirected to the "mul" site.

To understand the wanted behaviour, what is the wanted Site for a redirected 'code'?
Site('aa', 'wikisource') = ?
E.g. APISite("mul", "wikisource")?

Jan 14 2020, 10:49 PM · Upstream, Pywikibot-tests, Pywikibot
Mpaa created T242795: File deleted at Commons is no longer available even after page restore.
Jan 14 2020, 9:21 PM · SRE-swift-storage, MediaWiki-File-management, Commons

Jan 12 2020

Mpaa added a comment to T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.

Image width and height are always integer, but it seems that some files are now uploaded with float values

I think width and height are evaluated at run time (possibly cached), so I assume when this will be deployed, things will get back to normal.

Jan 12 2020, 9:57 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler

Jan 11 2020

Mpaa added a project to T242425: Wikidata shows different image (file) sizes, than Commons reports for the current version: MediaWiki-extensions-PdfHandler.
Jan 11 2020, 9:56 PM · MediaWiki-extensions-PdfHandler, Wikidata
Mpaa added a comment to T239510: No preview thumbnail generated for PDF on Commons: "Error: 429, Too Many Requests".

Duplicate of T188885?

Jan 11 2020, 8:38 PM · Thumbor, MediaWiki-extensions-PdfHandler
Mpaa added a comment to T242425: Wikidata shows different image (file) sizes, than Commons reports for the current version.

Dimensions are floats in both places now.

Jan 11 2020, 8:17 PM · MediaWiki-extensions-PdfHandler, Wikidata
Mpaa updated the task description for T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.
Jan 11 2020, 5:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa updated the task description for T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.
Jan 11 2020, 5:29 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa updated the task description for T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.
Jan 11 2020, 5:24 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa updated subscribers of T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.
Jan 11 2020, 5:21 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa updated subscribers of T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.

@Legoktm, @Umherirrender could you please take a look at this commit?
Is it intentional that the computation has been changed?
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PdfHandler/+/560127/2/includes/PdfImage.php

Jan 11 2020, 5:20 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler
Mpaa created T242517: Thumbnails for PDF files not found when width is not an Integer in URL link.
Jan 11 2020, 5:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, MediaWiki-extensions-PdfHandler

Jan 9 2020

Mpaa added a comment to T238992: [Feature Request]: Querying image description with Pywikibot API.

It's impossible to get image description from Commons via pywikibot API.
Because it is not exposed by mediawiki API, afaik.

Jan 9 2020, 9:35 PM · Pywikibot
Mpaa added a comment to T242169: Bad text layer extraction from PDFs.

But when I open the PDF document in my computer and copypaste the text into a word processor, it looks thus:
...passing safely through a country occupied by Sigismund's
troops, they arrived near Kralov6 Hradec. They called to...
This means that the original text layer of the PDF is good, only Mediawiki extracts it badly.

This is not indicative, it can depend on a lot of things (OS, browser, pdf plugin used, etc.). I tried once on Linux and two on Windows (one with AcrobatReader, one reading the pdf in Edge), and I got three different results.

Jan 9 2020, 8:27 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource

Jan 8 2020

Mpaa added a comment to T242169: Bad text layer extraction from PDFs.

@Jan.Kamenicek, I didn't mean that the text layer got improved by the djvu converting process.
Flags used with pdftotext command matters, and they are set in Mediawiki, see my comparison above.

Jan 8 2020, 11:37 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource
Mpaa added a comment to T242169: Bad text layer extraction from PDFs.

@Aklapper , I readded MediaWiki-extensions-PdfHandler as it seems relevant to me.

Jan 8 2020, 10:21 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource
Mpaa added a comment to T242169: Bad text layer extraction from PDFs.

This might be useful to understand pdftotext options.
https://github.com/EmpowermentZone/EdSharp/blob/master/Convert/Xpdf/pdftotext.txt

Jan 8 2020, 10:17 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource
Mpaa added a project to T242169: Bad text layer extraction from PDFs: MediaWiki-extensions-PdfHandler.
Jan 8 2020, 10:14 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource
Mpaa added a comment to T242169: Bad text layer extraction from PDFs.

Playing with "pdftotext" options, output can be similar to djvu text layer.

Jan 8 2020, 10:13 PM · MediaWiki-extensions-PdfHandler, ProofreadPage, Wikisource

Nov 16 2019

Mpaa added a comment to T238471: Performance problems with pywikibot's pagegenerator.

Have you considered to get data from dumps, if possible?

Nov 16 2019, 5:34 PM · Pywikibot-Wikidata, Wikidata, Pywikibot
Mpaa added a comment to T238448: Get family info from wikidata.

not all (special) projects are Wikidata clients.

Nov 16 2019, 9:13 AM · Pywikibot
Mpaa added a comment to T235500: Pywikibot cannot create new property.

@Xqt : hi, would you consider again this patch, currently I make this modification locally to have some code running

Nov 16 2019, 9:11 AM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot
Mpaa closed T238404: Pywikibot fails when importing entity Q1410828 as Invalid.
Nov 16 2019, 9:03 AM · Wikidata, Pywikibot

Nov 15 2019

Mpaa added a comment to T238404: Pywikibot fails when importing entity Q1410828.

Mhmmm .... on github I cannot find the "ban" language in the wikipedia_family:
https://github.com/wikimedia/pywikibot/blob/cbf194a60124fece9355517030aaa7091dcc093a/pywikibot/families/wikipedia_family.py
So would the newest version solve my problem?

Nov 15 2019, 11:12 PM · Wikidata, Pywikibot
Mpaa added a comment to T238404: Pywikibot fails when importing entity Q1410828.

I think it was added here: 2c565d01c381a858c4d02cf1f4c3372b589d5422

Nov 15 2019, 11:08 PM · Wikidata, Pywikibot
Mpaa created T238448: Get family info from wikidata.
Nov 15 2019, 9:01 PM · Pywikibot
Mpaa added a comment to T238404: Pywikibot fails when importing entity Q1410828.

Works for me, ban is already in wikipedia_family.py.
It is quite slow, though.

Nov 15 2019, 8:57 PM · Wikidata, Pywikibot

Nov 14 2019

Mpaa committed rPWBC25fe54476c30: Make _flush aware of _putthread ongoing tasks (authored by Mpaa).
Make _flush aware of _putthread ongoing tasks
Nov 14 2019, 7:36 AM

Nov 9 2019

Mpaa created T237834: ModuleDeprecationWrapper is not compatible with the feature 'autoreload' in ipython.
Nov 9 2019, 9:38 PM · Pywikibot

Oct 27 2019

Mpaa added a comment to T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character.

This is OS dependent, on Linux it is acceptable.

Oct 27 2019, 6:07 PM · Patch-For-Review, Pywikibot

Sep 22 2019

Mpaa committed rPWBC3df33cb77efd: site_tests.py: add test for site.assert_valid_iter_params (authored by Mpaa).
site_tests.py: add test for site.assert_valid_iter_params
Sep 22 2019, 6:05 PM
Mpaa committed rPWBCa38b6fa60909: site_tests.py: fix test_preload_templates_and_langlinks (authored by Mpaa).
site_tests.py: fix test_preload_templates_and_langlinks
Sep 22 2019, 12:38 PM

Aug 16 2019

Mpaa committed rPWBCd84a4bd77b4a: [bugfix] Fix the comparison in archivebot (authored by Mpaa).
[bugfix] Fix the comparison in archivebot
Aug 16 2019, 2:29 PM
Mpaa committed rPWBCdef0409c572f: proofreadpage.py: fix footer detection (authored by Mpaa).
proofreadpage.py: fix footer detection
Aug 16 2019, 12:42 PM

Aug 15 2019

Mpaa added a comment to T60546: Captcha support broken.

If you are going to submit a patch with the fix (plus possibly tests), it will be appreciated.
You can also use https://tools.wmflabs.org/gerrit-patch-uploader/ in case you do not want to go through the standard process (git/gerrit).

Aug 15 2019, 9:55 PM · Patch-For-Review, Pywikibot

Aug 13 2019

Mpaa committed rPWBC2baeca5c50f5: flake8: fix error C412-Unnecessary list comprehension (authored by Mpaa).
flake8: fix error C412-Unnecessary list comprehension
Aug 13 2019, 1:54 AM

Aug 11 2019

Mpaa added a project to T230301: Wrong footer detection in Proofreadpage: Pywikibot.
Aug 11 2019, 7:17 PM · Pywikibot
Mpaa created T230301: Wrong footer detection in Proofreadpage.
Aug 11 2019, 7:16 PM · Pywikibot

Aug 6 2019

Mpaa reopened T228587: Archivebot does not work anymore for me as "Open".

It also broke archiving on en.wikisource, which uses "User:Wikisource-bot/config".

Aug 6 2019, 1:42 PM · Pywikibot, Pywikibot-archivebot.py

Jul 18 2019

Mpaa committed rPWBCfc4b41510eba: archivebot.py: don't reorder template parameters (authored by Mpaa).
archivebot.py: don't reorder template parameters
Jul 18 2019, 9:49 PM

Jul 16 2019

Mpaa added a comment to T220828: archivebot.py: don't reorder template parameters.

Wouldn't loading config from self.page.raw_extracted_templates instead of self.page.templatesWithParams() keep the right order?

Jul 16 2019, 7:42 PM · Pywikibot, Pywikibot-archivebot.py

Jul 6 2019

Mpaa committed rPWBC638fe0ad00f0: proofreadpage_tests.py: Fix variable name (authored by Mpaa).
proofreadpage_tests.py: Fix variable name
Jul 6 2019, 8:44 AM
Mpaa committed rPWBC6c0523633be9: djvu.py: fix name of variable for filename (authored by Mpaa).
djvu.py: fix name of variable for filename
Jul 6 2019, 8:30 AM

Jun 18 2019

Mpaa added a comment to T225595: Some OCR-tests are failing at Appveyor.

It looks like googleOCR answer is not deterministic.
An option could be to check that at least x% of chars are equal instead of full equality.
The purpose is to check that the query to googleOCR is successful, not to test google algorithm.

Jun 18 2019, 7:48 PM · Pywikibot, Pywikibot-tests

Apr 9 2019

Mpaa added a comment to T219376: retrieveMetaData() in DjVuImage.php creates knock-on error when a page has invalid text layer.

See T214729

Apr 9 2019, 7:46 PM · Multimedia, MediaWiki-DjVu

Apr 1 2019

Mpaa added a comment to T219281: Move -except from add_text.py and -excepttext from replace.py to global page generator filters.

I would suggest -grep and -grepnot, similar to -titleregex and -titleregexnot.

Apr 1 2019, 9:16 PM · Pywikibot-replace.py, good first task, Pywikibot-pagegenerators.py, Pywikibot

Feb 16 2019

Mpaa added a comment to T212076: proofreadpage_tests.TestPageOCR.test_ocr_googleocr sometimes fails with ValueError.
Feb 16 2019, 6:58 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Feb 14 2019

Mpaa added a comment to T199042: touch.py makes empty edits on ProofreadPage pages.

Wikisource is needing to touch 000000s of files across multiple languages.

That should probably have its own bug report... extensions are expected to work correctly without constant bot maintenance.

Feb 14 2019, 8:56 PM · Patch-For-Review, Pywikibot-i18n, ProofreadPage, Pywikibot-Scripts, Pywikibot

Feb 11 2019

Dvorapa awarded T198452: Always enable namespace filtering in QueryGenerator a Like token.
Feb 11 2019, 12:18 AM · Pywikibot

Feb 3 2019

Mpaa added a comment to T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.

Note:
I fixed the file on Commons.
The buggy file is https://commons.wikimedia.org/w/index.php?title=File:Philosophical_Transactions_-_Volume_053.djvu&oldid=336270264

Feb 3 2019, 4:49 PM · good first task, ProofreadPage
Mpaa closed T215124: pagegenerators_tests.TestFactoryGenerator.test_linter_generator_show fails with UnknownExtension as Resolved.
Feb 3 2019, 4:32 PM · Patch-For-Review, Pywikibot, Pywikibot-tests

Feb 2 2019

Dvorapa awarded T214234: add -querypage parameter to pagegenerators a Manufacturing Defect? token.
Feb 2 2019, 11:45 PM · Patch-For-Review, Pywikibot-pagegenerators.py, Pywikibot

Jan 30 2019

Zoranzoki21 awarded T214234: add -querypage parameter to pagegenerators a Love token.
Jan 30 2019, 10:15 PM · Patch-For-Review, Pywikibot-pagegenerators.py, Pywikibot
Mpaa added a comment to T214923: Add -unusedcategories param.

I do not agree.
There is a patch proposing to introduce -querypage, which will be valid for all special pages, in order to avoid proliferation of argument.
See T214234.

Jan 30 2019, 7:59 PM · good first task, Pywikibot-Scripts, Pywikibot-pagegenerators.py, Pywikibot

Jan 26 2019

Mpaa added a comment to T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.

Something like this.

...
$txt = preg_replace_callback( $reg, [ $this, 'pageTextCallback' ], $txt );
$reg_failed = '/(?m)^failed$/'; 
$txt = preg_replace_callback( $reg_failed, [ $this, 'pageTextCallbackFailed' ], $txt );
txt = "<DjVuTxt>\n<HEAD></HEAD>\n<BODY>\n" . $txt . "</BODY>\n</DjVuTxt>\n";
Jan 26 2019, 5:12 PM · good first task, ProofreadPage

Jan 25 2019

Mpaa added a comment to T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.

The improvement is to be done in DjVuImage.php: function retrieveMetaData()
https://doc.wikimedia.org/mediawiki-core/master/php/DjVuImage_8php_source.html#l00246

Jan 25 2019, 11:36 PM · good first task, ProofreadPage
Mpaa added a comment to T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.

It is the djvutxt that fails for this page 51:

Jan 25 2019, 9:51 PM · good first task, ProofreadPage
Mpaa added a comment to T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.

I guess the problem might lie somewhere here:
https://doc.wikimedia.org/mediawiki-core/master/php/DjVuImage_8php_source.html#l00308

Jan 25 2019, 9:30 PM · good first task, ProofreadPage
Mpaa created T214729: Error during parsing of djvu text layer to produce metadata leads to page offset in ProofreadPage extension.
Jan 25 2019, 9:16 PM · good first task, ProofreadPage

Jan 19 2019

Mpaa created T214234: add -querypage parameter to pagegenerators.
Jan 19 2019, 11:42 AM · Patch-For-Review, Pywikibot-pagegenerators.py, Pywikibot

Jan 16 2019

Mpaa added a comment to T213904: Implement file captions in Pywikibot.

https://commons.wikimedia.org/wiki/Commons:File_captions#How_can_I_query_the_captions_using_the_API?

Jan 16 2019, 9:19 PM · StructuredDataOnCommons, Pywikibot

Jan 5 2019

Mpaa closed T205190: code cleanup: remove deprecation warning for -dry option in basic.py as Resolved.
Jan 5 2019, 4:49 PM · Patch-For-Review, Pywikibot

Jan 4 2019

Mpaa added a comment to T212741: classes derived from object should always call super in Initializer.

Not sure this is a bug or a must, it is more about how you want the classes to cooperate with each other.
MRO chain is not broken in the first example, the design is such that the chain of calls does not propagate all the way up (it might also be a design choice, see e.g. https://rhettinger.wordpress.com/2011/05/26/super-considered-super/#comment-86).

Jan 4 2019, 10:49 PM · Pywikibot

Dec 29 2018

Mpaa added a comment to T205155: unconnected_pages generator doesn't seem to return all pages.

qpoffset is used, the issue is same as T173293.

Dec 29 2018, 9:08 PM · Pywikibot, Pywikibot-Wikidata

Dec 19 2018

Mpaa added a comment to T212076: proofreadpage_tests.TestPageOCR.test_ocr_googleocr sometimes fails with ValueError.

I copy it here for convenience.
Interesting, it looks like googleOCR answer is not deterministic or some bytes are lost somewhere.

Dec 19 2018, 6:06 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Dec 16 2018

Mpaa updated subscribers of T211813: SSL CERTIFICATE_VERIFY_FAILED on generating family file.
Dec 16 2018, 6:09 PM
Mpaa removed a project from T211813: SSL CERTIFICATE_VERIFY_FAILED on generating family file: Pywikibot.
Dec 16 2018, 6:09 PM
Mpaa added a comment to T212076: proofreadpage_tests.TestPageOCR.test_ocr_googleocr sometimes fails with ValueError.

I think it is has been a temporary unavailability of googleOCR service.

Dec 16 2018, 6:08 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Dec 12 2018

Mpaa added a comment to T211813: SSL CERTIFICATE_VERIFY_FAILED on generating family file.

I don't think it is a pywikibot issue.

Dec 12 2018, 9:11 PM

Nov 25 2018

Mpaa added a comment to T210335: proofreadpage_tests.TestPageOCR fails in some test builds.

OK, we worked at the same time.
Added more check in proofreadpage.py
PYSETUP_TEST_EXTRAS=1 installs bs4

Nov 25 2018, 10:20 AM · Patch-For-Review, Pywikibot-tests, Pywikibot

Nov 24 2018

Mpaa added a comment to T210335: proofreadpage_tests.TestPageOCR fails in some test builds.

It fails on:

"env": "LANGUAGE=en FAMILY=wikipedia PYWIKIBOT_TEST_PROD_ONLY=1",

and pass on:

"env": "LANGUAGE=zh FAMILY=wikisource PYSETUP_TEST_EXTRAS=1 PYWIKIBOT_TEST_PROD_ONLY=1 PYWIKIBOT_TEST_NO_RC=1",

so I guess it is related to family.

Nov 24 2018, 10:36 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Mpaa created T210335: proofreadpage_tests.TestPageOCR fails in some test builds.
Nov 24 2018, 9:58 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Nov 23 2018

Mpaa added a comment to T205223: Update TestProofreadPageValidSite.test_json_format to not use the deprecated `rvcontentformat` parameter.

This is not correct.
proofreadpage.py uses "contentformat" in edit action, which is not deprecated. See https://en.wikisource.org/w/api.php?action=help&modules=edit

Nov 23 2018, 9:58 PM · Pywikibot-tests, Pywikibot

Nov 19 2018

Mpaa added a comment to T209798: Enable unexpected successes?.

proofreadpage_tests are still waiting for upstream fixes.

Nov 19 2018, 8:09 PM · Pywikibot-tests, Pywikibot

Nov 15 2018

Mpaa added a comment to T209111: APIError: too-many-titles with -start: page generator.

The problem is that in site.preloadpages(), max_ids is computed after the pageslist is splitted in chunks of 240.

for sublist in itergroup(pagelist, groupsize):   <----------- groupsize = 240
    # Do not use p.pageid property as it will force page loading.
    pageids = [str(p._pageid) for p in sublist
               if hasattr(p, '_pageid') and p._pageid > 0]
    cache = {}
    # In case of duplicates, return the first entry.
    for priority, page in enumerate(sublist):
        try:
            cache.setdefault(page.title(with_section=False),
                             (priority, page))
        except pywikibot.InvalidTitle:
            pywikibot.exception()
Nov 15 2018, 10:06 PM · Patch-For-Review, Pywikibot-pagegenerators.py, Pywikibot

Oct 19 2018

Mpaa added a comment to T201904: Add "pagequality" right to User rights when logged in via OAuth.

Thank you.

Oct 19 2018, 8:31 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), ProofreadPage, MediaWiki-Authentication-and-authorization

Oct 18 2018

Mpaa added a comment to T201904: Add "pagequality" right to User rights when logged in via OAuth.

@JJMC89. could you please elaborate about it? So I might try to look into it. Thanks

Oct 18 2018, 7:55 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), ProofreadPage, MediaWiki-Authentication-and-authorization

Aug 25 2018

Mpaa added a comment to T113450: pywikibot-touch.py needs to operate in bot mode.

I am afraid, this is not because bot is broken, but because database is broken.

File a bug against Wikimedia-Rdbms. Pywikibot itself has nothing to do with this.

Aug 25 2018, 12:33 PM · Pywikibot-touch.py, good first task, Pywikibot

Aug 20 2018

Mpaa added a comment to T202200: Visual Editor set double header in ProofreadPage header.

BTW, I could not find a way to edit a page directly in VE. So I need to switch.

Aug 20 2018, 9:33 PM · ProofreadPage, VisualEditor
Mpaa added a comment to T202200: Visual Editor set double header in ProofreadPage header.

Hi. Also here I switched from wikitext to VE. And then just save, no other actions.

Aug 20 2018, 9:29 PM · ProofreadPage, VisualEditor
Mpaa added a comment to T202197: Visual Editor removes user from ProofreadPage header.

I don't think this needed to be marked as "Unbreak Now!". The issue has existed for a while, and ProofreadPage is able to deal with missing or invalid usernames given in the "user" field (it must be – existing usernames already saved in existing content can become invalid, e.g. when the user is renamed).
But, since I already investigated it, there's not a lot of work to actually make the patch…

Aug 20 2018, 9:22 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), ProofreadPage, VisualEditor