cannot import name 'httplib' from 'urllib3.response during "pywikibot-core-tox-fasttest-py37-docker"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Mpaa
	Nov 11 2020, 9:46 PM

Description

See https://integration.wikimedia.org/ci/job/pywikibot-core-tox-fasttest-py37-docker/1535/console
The same is valid for py35.

22:24:57 ======================================================================
22:24:57 ERROR: Failure: ImportError (cannot import name 'httplib' from 'urllib3.response' (/src/.tox/fasttest-py37/lib/python3.7/site-packages/urllib3/response.py))
22:24:57 ----------------------------------------------------------------------
22:24:57 Traceback (most recent call last):
22:24:57   File "/src/.tox/fasttest-py37/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
22:24:57     raise self.exc_val.with_traceback(self.tb)
22:24:57   File "/src/.tox/fasttest-py37/lib/python3.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
22:24:57     addr.filename, addr.module)
22:24:57   File "/src/.tox/fasttest-py37/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
22:24:57     return self.importFromDir(dir_path, fqname)
22:24:57   File "/src/.tox/fasttest-py37/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
22:24:57     mod = load_module(part_fqname, fh, filename, desc)
22:24:57   File "/usr/lib/python3.7/imp.py", line 234, in load_module
22:24:57     return load_source(name, filename, file)
22:24:57   File "/usr/lib/python3.7/imp.py", line 171, in load_source
22:24:57     module = _load(spec)
22:24:57   File "<frozen importlib._bootstrap>", line 696, in _load
22:24:57   File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
22:24:57   File "<frozen importlib._bootstrap_external>", line 728, in exec_module
22:24:57   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
22:24:57   File "/src/tests/eventstreams_tests.py", line 14, in <module>
22:24:57     from pywikibot.comms.eventstreams import EventStreams, EventSource
22:24:57   File "/src/pywikibot/comms/eventstreams.py", line 25, in <module>
22:24:57     from requests.packages.urllib3.response import httplib
22:24:57 ImportError: cannot import name 'httplib' from 'urllib3.response' (/src/.tox/fasttest-py37/lib/python3.7/site-packages/urllib3/response.py)

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] fix import of httplib after release of requests 2.25	pywikibot/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T269692: from requests.packages.urllib3.response import httplib failing
rPWBCe079472eab6d: [bugfix] fix import of httplib after release of requests 2.25
Mentioned Here: T168535: EventStreams might fail with httplib.IncompleteRead error

Event Timeline

Mpaa created this task.Nov 11 2020, 9:46 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptNov 11 2020, 9:46 PM

New versions of requests and urllib3 were released today.

https://github.com/psf/requests/blob/master/HISTORY.md

2.25.0 (2020-11-11)
------------------

**Improvements**

- Added support for NETRC environment variable. (#5643)

**Dependencies**

- Requests now supports urllib3 v1.26.

https://github.com/urllib3/urllib3/blob/master/CHANGES.rst

Might be related and an upstream issue.

Definitely. I tried to install from scratch:

(myenv)user@pc:~/python/work {master}$ python
Python 3.8.5 (default, Sep  4 2020, 07:30:14) 
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> from requests.packages.urllib3.response import httplib
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'httplib' from 'urllib3.response' (/home/user/anaconda3/envs/myenv/lib/python3.8/site-packages/urllib3/response.py)
>>> requests.__version__
'2.25.0'
>>> import urllib3
>>> urllib3.__version__
'1.26.1'
>>>

OK, it might be this:
https://github.com/urllib3/urllib3/commit/d71c784053dbf53b7cf2511f81232102a6a2ec76#diff-008f01f06c84456177464927734cc849c073b1f3d13bfab947ff812a5b4ac965L27

I think we can import it from here:
https://github.com/urllib3/urllib3/blob/master/src/urllib3/util/response.py#L6
It should also be backward compatible, that import is there since 5 years ago.

Change 640724 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] [bugfix] fix import of httplib after rlease of requests 2.25

https://gerrit.wikimedia.org/r/640724

gerritbot added a project: Patch-For-Review.Nov 11 2020, 10:58 PM

Xqt triaged this task as High priority.Nov 12 2020, 12:23 AM

Xqt changed the subtype of this task from "Task" to "Bug Report".

See T168535

Xqt closed this task as Resolved.Nov 12 2020, 9:09 AM

Xqt assigned this task to Mpaa.

Change 640724 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] fix import of httplib after release of requests 2.25

https://gerrit.wikimedia.org/r/640724

Mpaa mentioned this in rPWBCe079472eab6d: [bugfix] fix import of httplib after release of requests 2.25.Nov 12 2020, 9:15 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 12 2020, 10:10 AM

Xqt mentioned this in T269692: from requests.packages.urllib3.response import httplib failing.Dec 8 2020, 4:59 PM