Gadget-PrimarySources throws JS error: Uncaught TypeError: async.parallel is not a function
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Raymond
	Dec 2 2023, 4:51 PM

Description

Steps to replicate the issue (include links if applicable):

Call a Wikidata item
Open the browser console

What happens?:

JS error is shown (with URL parameter &debug=true)

Uncaught TypeError: async.parallel is not a function
  init https://www.wikidata.org/w/load.php?debug=1&lang=de&modules=ext.gadget.PrimarySources&only=scripts&skin=vector&version=ztntf:651
  <anonymous> https://www.wikidata.org/w/load.php?debug=1&lang=de&modules=ext.gadget.PrimarySources&only=scripts&skin=vector&version=ztntf:675
  jQuery 11
  <anonymous> https://www.wikidata.org/w/load.php?debug=1&lang=de&modules=ext.gadget.PrimarySources&only=scripts&skin=vector&version=ztntf:126

This happens since this week. Maybe related to T343499 / https://gerrit.wikimedia.org/r/c/mediawiki/libs/Minify/+/948986/ ?

The gadget JS files were last edited in April 2021 MediaWiki:Gadget-PrimarySources.js and 2015 MediaWiki:Gadget-PrimarySources-async.js

Please note: The gadget was disabled now.

Related Objects

Mentioned Here: T343499: Add minification support for async-await (ES2017)

Event Timeline

Raymond created this task.Dec 2 2023, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2023, 4:51 PM

Maintenance_bot added a project: Wikidata.Dec 2 2023, 5:29 PM

Since native Promise is supported now, what about migrating the gadget to that, dropping the Async.js dependency? Including minified JS (the Async.js code in this case) on wiki pages isn’t a best practice anyway.

+1 to @Tacsipacsi. It's probably the best way to go. Would someone have time to do it? Help would very much welcomed

Raymond updated the task description. (Show Details)Dec 3 2023, 1:52 PM

matej_suchanek merged a task: T352599: Non-working gadgets on Wikidata .Dec 3 2023, 3:19 PM

matej_suchanek added a subscriber: Miikul.

Gadget-PrimarySources throws JS error: Uncaught TypeError: async.parallel is not a functionOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Gadget-PrimarySources throws JS error: Uncaught TypeError: async.parallel is not a function
Open, Needs TriagePublicBUG REPORT
Actions