Page MenuHomePhabricator

GlobalWatchlist styles should load or duplicate autocomment and history-deleted styling
Closed, ResolvedPublic1 Estimated Story Points

Description

I think we used to have the styles for the automatic section headings in edit summaries loaded for the global watchlist, but we don't currently - maybe for the same reason as T287649: Regression wmf.16: New vector no longer aligns sites correctly ?

Also for hidden user names with the class history-deleted

We can load the entire mediawiki.interface.helpers.styles module as a dependency, but that seems like overkill - all we need is

/* The auto-generated edit comments */
.autocomment,
.autocomment a,
.autocomment a:visited {
	color: #72777d;
}

/** rev_deleted stuff */
span.history-deleted {
	text-decoration: line-through;
	color: #72777d;
	font-style: italic;
}

From https://gerrit.wikimedia.org/g/mediawiki/core/+/63da9a14300c212c678b147f5703ffa356a452c7/resources/src/mediawiki.interface.helpers.styles.less

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 renamed this task from GlobalWatchlist styles should load or duplicate autocomment styling to GlobalWatchlist styles should load or duplicate autocomment and history-deleted styling.Aug 16 2021, 9:35 AM
DannyS712 updated the task description. (Show Details)

Change 712960 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Add autocomment and history-deleted styles

https://gerrit.wikimedia.org/r/712960

Change 712960 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Add autocomment and history-deleted styles

https://gerrit.wikimedia.org/r/712960

DannyS712 set the point value for this task to 1.
DannyS712 moved this task from Backlog to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 2.

Not worth backporting, will be part of the next train and reach meta in two days