Page MenuHomePhabricator
Create Task
Maniphest T290398

renameRestrictions.php should also update protected_titles table
Closed, ResolvedPublic
Actions

Description

There's a maintenance script called renameRestrictions.php that can be used to rename a restriction level from one name to another. However, it only takes care of the page_restrictions table -- it ignores protected_titles which uses the same concept.

This likely caused a bunch of cases similar to T290396 that no one noticed yet :/.

Details

SubjectRepoBranchLines +/-
renameRestrictions.php: Update protected_titles as wellmediawiki/coreREL1_36+9 -2
renameRestrictions.php: Update protected_titles as wellmediawiki/coreREL1_35+9 -2
renameRestrictions.php: Update protected_titles as wellmediawiki/corewmf/1.37.0-wmf.21+11 -4
renameRestrictions.php: Update protected_titles as wellmediawiki/coremaster+11 -4
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Sep 5 2021, 7:00 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptSep 5 2021, 7:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm triaged this task as High priority.Sep 5 2021, 7:02 PM
gerritbot added a comment.Sep 5 2021, 7:02 PM

Change 718921 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/718921

gerritbot added a project: Patch-For-Review.Sep 5 2021, 7:02 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Sep 5 2021, 7:03 PM
gerritbot added a comment.Sep 6 2021, 5:41 AM

Change 718921 merged by jenkins-bot:

[mediawiki/core@master] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/718921

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 6 2021, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 6 2021, 6:10 AM
gerritbot added a comment.Sep 6 2021, 10:03 AM

Change 719069 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.21] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719069

gerritbot added a project: Patch-For-Review.Sep 6 2021, 10:03 AM
gerritbot added a comment.Sep 6 2021, 10:40 AM

Change 719058 had a related patch set uploaded (by Majavah; author: Urbanecm):

[mediawiki/core@REL1_36] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719058

gerritbot added a comment.Sep 6 2021, 10:41 AM

Change 719059 had a related patch set uploaded (by Majavah; author: Urbanecm):

[mediawiki/core@REL1_35] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719059

gerritbot added a comment.Sep 6 2021, 10:48 AM

Change 719069 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.21] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719069

gerritbot added a comment.Sep 6 2021, 10:52 AM

Change 719059 merged by jenkins-bot:

[mediawiki/core@REL1_35] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719059

gerritbot added a comment.Sep 6 2021, 10:55 AM

Change 719058 merged by jenkins-bot:

[mediawiki/core@REL1_36] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719058

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.36-notes, MW-1.35-notes; removed MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 6 2021, 11:00 AM
Stashbot added a comment.Sep 6 2021, 11:02 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-06T11:02:34Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.21/maintenance/renameRestrictions.php: rMW18e43ecca7d2: renameRestrictions.php: Update protected_titles as well (T290398) (duration: 00m 59s)

Urbanecm closed this task as Resolved.Sep 6 2021, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits