Page MenuHomePhabricator

renameRestrictions.php should also update protected_titles table
Closed, ResolvedPublic

Description

There's a maintenance script called renameRestrictions.php that can be used to rename a restriction level from one name to another. However, it only takes care of the page_restrictions table -- it ignores protected_titles which uses the same concept.

This likely caused a bunch of cases similar to T290396 that no one noticed yet :/.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm triaged this task as High priority.Sun, Sep 5, 7:02 PM

Change 718921 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/718921

Change 718921 merged by jenkins-bot:

[mediawiki/core@master] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/718921

Change 719069 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.21] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719069

Change 719058 had a related patch set uploaded (by Majavah; author: Urbanecm):

[mediawiki/core@REL1_36] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719058

Change 719059 had a related patch set uploaded (by Majavah; author: Urbanecm):

[mediawiki/core@REL1_35] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719059

Change 719069 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.21] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719069

Change 719059 merged by jenkins-bot:

[mediawiki/core@REL1_35] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719059

Change 719058 merged by jenkins-bot:

[mediawiki/core@REL1_36] renameRestrictions.php: Update protected_titles as well

https://gerrit.wikimedia.org/r/719058

Mentioned in SAL (#wikimedia-operations) [2021-09-06T11:02:34Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.21/maintenance/renameRestrictions.php: 18e43ecca7d25d2d93de2f98f3bf5b36f5d4b780: renameRestrictions.php: Update protected_titles as well (T290398) (duration: 00m 59s)